Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358941 - AbstractStructuredGraphViewer.reveal(...) implemented incorrectly
Summary: AbstractStructuredGraphViewer.reveal(...) implemented incorrectly
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Zest (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Zoltan Ujhelyi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 13:43 EDT by Martin Burger CLA
Modified: 2012-10-09 19:02 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (75.46 KB, application/octet-stream)
2012-10-09 19:01 EDT, Zoltan Ujhelyi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Burger CLA 2011-09-26 13:43:54 EDT 
According to the API specification (Javadoc comment) of method StructuredViewer.reveal(...), this method is supposed to ensure that the given element is visible, scrolling the viewer if necessary; the selection is unchanged.

However, class AbstractStructuredGraphViewer seems to violate the API contract, as it implements the specified behavior incorrectly. Method AbstractStructuredGraphViewer.reveal(...) highlights the given node and connection, respectively, but does not scroll the viewer if necessary. If the given node / connection to be revealed is not visible, nothing happens. Thus, that object is still not visible after calling AbstractStructuredGraphViewer.reveal(...).
Comment 1 Zoltan Ujhelyi CLA 2012-10-09 19:01:01 EDT 
Created attachment 222092 [details]
mylyn/context/zip

Attached Mylyn context
Comment 2 Zoltan Ujhelyi CLA 2012-10-09 19:02:01 EDT 
Fixed for Zest 2.0 in master.