Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358932 - Backport to 3.2.x [performance] DefaultFileServiceCodePageConverter is wasteful with main memory
Summary: Backport to 3.2.x [performance] DefaultFileServiceCodePageConverter is wastef...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2+   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 280453
Blocks:
  Show dependency tree
 
Reported: 2011-09-26 13:04 EDT by David McKnight CLA
Modified: 2012-03-20 15:34 EDT (History)
2 users (show)

See Also:
xuanchen: review+

Attachments
backport patch (5.44 KB, patch)
2011-12-09 12:06 EST, David McKnight CLA 		no flags Details | Diff
update with fix for rename (1.40 KB, patch)
2012-03-20 15:29 EDT, David McKnight CLA 		no flags Details | Diff
update with fix for rename (1.37 KB, text/plain)
2012-03-20 15:31 EDT, David McKnight CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-09-26 13:04:08 EDT 
This bug is for the backport of the fix for bug 280453 to the R3_2_maintenance stream.
Comment 1 John W Snyder CLA 2011-12-09 11:24:06 EST 
Hi David... any idea when this backport will be completed?
Comment 2 David McKnight CLA 2011-12-09 12:06:10 EST 
Created attachment 208181 [details]
backport patch
Comment 3 David McKnight CLA 2011-12-09 12:06:36 EST 
Xuan, could you please review this backport?
Comment 4 David McKnight CLA 2011-12-09 12:07:09 EST 
(In reply to comment #1)
> Hi David... any idea when this backport will be completed?

John, I didn't know you guys needed this now.  I'll let you know when it's complete.
Comment 5 Xuan Chen CLA 2011-12-09 16:44:24 EST 
The fix looks good.  Thanks.
Comment 6 David McKnight CLA 2011-12-09 16:51:35 EST 
Thanks for the patch, Xuan.  I've committed the fix to the R3_2_maintenance stream.
Comment 7 David McKnight CLA 2012-03-20 15:22:44 EDT 
Reopening this because the call to:

altFile.renameTo(file);

is problemmatic.  java.io.File.renameTo() doesn't work when the file already
exists.
Comment 8 David McKnight CLA 2012-03-20 15:29:57 EDT 
Created attachment 212943 [details]
update with fix for rename
Comment 9 David McKnight CLA 2012-03-20 15:31:18 EDT 
Created attachment 212944 [details]
update with fix for rename
Comment 10 David McKnight CLA 2012-03-20 15:34:35 EDT 
I committed the update to the maintenance stream.