Community
Participate
Working Groups
1.1.0.201109151100-r The Team > Advanced > Tag... dialog locks up for more than 5 minutes when I try to expand the Advanced twistie. One processor is maxed out and stacktraces all end up in CommitCombo.add(CommitCombo.java:155). Happened on the eclipse.jdt.ui Git repository, which has a huge commit history and a lot of tags. I did this on a GTK machine. When I clicked the Combo dropdown button, this locked the entire machine for another 5 minutes. "main" prio=10 tid=0x080afc00 nid=0x3d7b runnable [0xbfde7000..0xbfde9088] java.lang.Thread.State: RUNNABLE at org.eclipse.swt.internal.gtk.OS._gtk_combo_box_insert_text(Native Method) at org.eclipse.swt.internal.gtk.OS.gtk_combo_box_insert_text(OS.java:6424) at org.eclipse.swt.widgets.Combo.add(Combo.java:173) at org.eclipse.swt.widgets.Combo.add(Combo.java:134) at org.eclipse.egit.ui.internal.dialogs.CommitCombo.add(CommitCombo.java:155) ... "main" prio=10 tid=0x080afc00 nid=0x3d7b runnable [0xbfde7000..0xbfde9088] java.lang.Thread.State: RUNNABLE at org.eclipse.swt.internal.Converter.wcsToMbcs(Converter.java:53) at org.eclipse.swt.widgets.Combo.add(Combo.java:171) at org.eclipse.swt.widgets.Combo.add(Combo.java:134) at org.eclipse.egit.ui.internal.dialogs.CommitCombo.add(CommitCombo.java:155) at org.eclipse.egit.ui.internal.dialogs.CreateTagDialog$6.expansionStateChanged(CreateTagDialog.java:516) at org.eclipse.ui.forms.widgets.ExpandableComposite.fireExpanding(ExpandableComposite.java:1081) at org.eclipse.ui.forms.widgets.ExpandableComposite.toggleState(ExpandableComposite.java:1065) at org.eclipse.ui.forms.widgets.ExpandableComposite.programmaticToggleState(ExpandableComposite.java:1115) at org.eclipse.ui.forms.widgets.ExpandableComposite.access$7(ExpandableComposite.java:1112) at org.eclipse.ui.forms.widgets.ExpandableComposite$7.handleEvent(ExpandableComposite.java:636) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209) at org.eclipse.jface.window.Window.runEventLoop(Window.java:825) at org.eclipse.jface.window.Window.open(Window.java:801) at org.eclipse.egit.ui.internal.actions.TagActionHandler.execute(TagActionHandler.java:71) at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293) at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476) at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508) at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169) at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241) at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241) at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:829) at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:815) at org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:805) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579) at org.eclipse.equinox.launcher.Main.run(Main.java:1431)
I almost missed the build input because of this.
Fix proposed: http://egit.eclipse.org/r/4325
Merged as b87c3044989c0024be57607a8de71f3914509d6b
Verified in 1.2.0.201110190928.