Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358920 - [DataBinding] WorkbenchProperties.SelectionServiceListener ignores arguments given to selectionChanged() when delegating to NativePropertyListener.fireChanged()
Summary: [DataBinding] WorkbenchProperties.SelectionServiceListener ignores arguments ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7.2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 349297
Blocks:
  Show dependency tree
 
Reported: 2011-09-26 11:52 EDT by Dani Megert CLA
Modified: 2011-12-13 02:55 EST (History)
8 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-09-26 11:52:24 EDT 
Backport request for bug bug 349297.

The inner class SelectionServiceListener always calls its inherited method fireChanged() with arguments (null, null) ignoring the part and selection passed to selectionChanged(). The super class NativePropertyListener creates a new SimplePropertyEvent in fireChanged() and passes through the null values. This results in an IllegalArgumentException ("null source") in the constructor of SimplePropertyEvent/EventObject. Due to this fact the provided WorkbenchProperties are unusable.
Comment 1 Dani Megert CLA 2011-10-26 04:51:45 EDT 
NOTE: This also needs to be cherry-picked into R4_maintenance.
Comment 2 Dani Megert CLA 2011-11-08 03:26:40 EST 
Paul, please approve for 3.7.2/4.1.2.
Comment 3 Paul Webster CLA 2011-11-08 07:27:15 EST 
I agree.

PW
Comment 4 Dani Megert CLA 2011-11-08 08:31:15 EST 
Fixed in R3_7_maintenance: 4cf77281d87a268a9e2963d94c740f33e8bb6b34
Comment 5 Dani Megert CLA 2011-12-13 02:55:08 EST 
Verified in M20111212-1000.