Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358888 - Backport to 3.0.x [performance] DefaultFileServiceCodePageConverter is wasteful with main memory
Summary: Backport to 3.0.x [performance] DefaultFileServiceCodePageConverter is wastef...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.3+   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 280453
Blocks:
  Show dependency tree
 
Reported: 2011-09-26 09:32 EDT by David McKnight CLA
Modified: 2012-03-20 15:52 EDT (History)
1 user (show)

See Also:
xuanchen: review+

Attachments
backport patch (6.96 KB, patch)
2011-09-26 09:35 EDT, David McKnight CLA 		no flags Details | Diff
update with fix for rename (1.37 KB, patch)
2012-03-20 15:35 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-09-26 09:32:13 EDT 
This bug is for the backport of the fix for bug 280453 to the R3_0_maintenance stream.
Comment 1 David McKnight CLA 2011-09-26 09:35:03 EDT 
Created attachment 204009 [details]
backport patch
Comment 2 David McKnight CLA 2011-09-27 09:54:05 EDT 
Kevin, could you please review this backport patch?
Comment 3 David McKnight CLA 2011-10-06 09:45:11 EDT 
Xuan, could you please review this backport?
Comment 4 Xuan Chen CLA 2011-10-06 11:10:49 EDT 
The fix looks good.  Thanks.
Comment 5 David McKnight CLA 2011-10-06 11:20:53 EDT 
Thanks for the review, Xuan.  I've committed the fix to the R3_0_maintenance stream.
Comment 6 David McKnight CLA 2012-03-20 15:22:30 EDT 
Reopening this because the call to:

altFile.renameTo(file);

is problemmatic.  java.io.File.renameTo() doesn't work when the file already
exists.
Comment 7 David McKnight CLA 2012-03-20 15:35:03 EDT 
Created attachment 212945 [details]
update with fix for rename
Comment 8 David McKnight CLA 2012-03-20 15:52:30 EDT 
I've committed the fix to the legacy stream.