Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358806 - ContextinjectionFactory.make() is not thread safe
Summary: ContextinjectionFactory.make() is not thread safe
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-runtime-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-24 16:15 EDT by Bryan Hunt CLA
Modified: 2019-11-27 07:17 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Hunt CLA 2011-09-24 16:15:15 EDT 
ContextInjectionFactory.make() calls InjectorImpl.make() which then calls InjectorImpl.internalMake() which accesses classesBeingCreated outside of a synchronized context.  If two different threads both call ContextInjectionFactory.make() with the same class, you can get an InjectionException.  Looking at the accesses to classesBeingCreated, it appears that the function was designed to be recursive, but I can't find any recursive calls the internalMake.  It seems that classesBeingCreated could be removed.
Comment 1 Lars Vogel CLA 2019-11-27 07:17:53 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.