Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358788 - [PerspectiveBar] Perspective switcher renders text after a save even if the text rendering has been disabled
Summary: [PerspectiveBar] Perspective switcher renders text after a save even if the t...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Dean Roberts CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 19:02 EDT by Remy Suen CLA
Modified: 2011-10-26 14:55 EDT (History)
4 users (show)

See Also:

Attachments
Fix text rendering for saved perspectives (1.75 KB, patch)
2011-10-12 14:40 EDT, Dean Roberts CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-09-23 19:02:16 EDT 
1. Right-click on a perspective > Show Text > Uncheck it.
2. Window > Save Perspective As... > Give it a name > OK
3. The perspective's tool item now has text next to it again.
Comment 1 Eric Moffatt CLA 2011-10-11 15:07:49 EDT 
Dean, could you look at this one as well ? I thought that 'show text' was an SWT style-bit change but I guess not...
Comment 2 Dean Roberts CLA 2011-10-12 14:40:39 EDT 
Created attachment 205062 [details]
Fix text rendering for saved perspectives

This patch also contains a fix for updating the tool tip on the PerspectiveSwitcher ToolItem for saved perspectives.

The tool tip problem is not visible until the set text problem was fixed.  Since the tool tip fix is a one line change and is closely related to the set text fix, I decided to include it in the same patch.

If the fixes need to be submitted separately then the change in PerspectiveSwitcher fixes the setText issue and the change in WorkbenchWindow fixes the tool tip issue.
Comment 3 Remy Suen CLA 2011-10-12 16:01:45 EDT 
(In reply to comment #2)
> Created attachment 205062 [details]
> Fix text rendering for saved perspectives

Oleg, could you review this patch? Figure we should spread the code review out a bit amongst the team members as we discussed on last week's Eclipse 4 call.
Comment 4 Oleg Besedin CLA 2011-10-13 13:54:47 EDT 
(In reply to comment #3)
> Oleg, could you review this patch?

Looks good, I committed the change into R4_dev:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=8cceb01b013ce4fec78ad8a5c5e6fb4decf094fb

Thanks Dean!
Comment 5 Remy Suen CLA 2011-10-13 16:07:53 EDT 
Comment on attachment 205062 [details]
Fix text rendering for saved perspectives

Dean is a committer on the e4 project, a project under the Eclipse top-level project, so the iplog flag is not required for his patches.
Comment 6 Dean Roberts CLA 2011-10-26 14:55:08 EDT 
Verified on I20111014-1625