Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358786 - Better Email address validation is needed
Summary: Better Email address validation is needed
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 359751 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-09-23 18:29 EDT by Sebastien Dubois CLA
Modified: 2012-01-24 17:46 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Dubois CLA 2011-09-23 18:29:36 EDT 
Currently, when trying to send emails from R4E, we only check if the email address is filled with some characters.  There is a need to validate the the email address is in a correct format.  We should introduce a validation method for this
Comment 1 Jacques Bouthillier CLA 2011-09-26 10:44:15 EDT 
On LINUX environment, the SMTP mail should validate the destination, otherwise, a ComponentObjectModelException: null address occurs. When testing on window environment, an empty address or an invalid address trigger a pop-up and no exception .


LINUX tracing:
org.eclipse.core.runtime.CoreException: ComponentObjectModelException: Null address
	at org.eclipse.mylyn.reviews.r4e.mail.smtp.mailVersion.Smtp.sendEmail(Smtp.java:119)
	at org.eclipse.mylyn.reviews.r4e.mail.smtp.mailVersion.Smtp.sendEmailGraphical(Smtp.java:153)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.utils.MailServicesProxy.sendMessage(MailServicesProxy.java:305)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.utils.MailServicesProxy.sendQuestion(MailServicesProxy.java:275)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.SendNotificationHandler$1.runInUIThread(SendNotificationHandler.java:124)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3563)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3212)
Comment 2 Sebastien Dubois CLA 2011-10-05 23:08:53 EDT 
*** Bug 359751 has been marked as a duplicate of this bug. ***
Comment 3 Sebastien Dubois CLA 2011-10-17 11:39:51 EDT 
All email addresses are now validated according to RFC5322.  Invalid values are flagged to the user and will not be accepted