Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358739 - MinMaxAddon has a dependency on o.e.u.workbench
Summary: MinMaxAddon has a dependency on o.e.u.workbench
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 11:37 EDT by Eric Moffatt CLA
Modified: 2012-01-24 13:44 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-09-23 11:37:22 EDT 
This was introduced by me late in M2 in order to get the animation effects out for review.

We should likely just clone the required classes into some consumable e4 bundle...

At the same time we should move the MinMax constants out of the addon itself and into IPresentationEngine (with comments indicating that presentation engine implementations should honor these tags if they support min/max). This will allow us to remove the current hack in WorkbenchPage where we are using copies of these strings directly.
Comment 1 Eric Moffatt CLA 2011-09-23 15:48:07 EDT 
Remy, any idea what a good candidate would be to copy the animation classes into ?
Comment 2 Remy Suen CLA 2011-09-23 16:13:41 EDT 
(In reply to comment #1)
> Remy, any idea what a good candidate would be to copy the animation classes
> into ?

Are you planning to make them into API?
Comment 3 Eric Moffatt CLA 2011-09-27 15:41:38 EDT 
Offhand I'd say yes, the AnimationEngine might be quite useful for e4 RCP apps so they can do their own effects.

IIRC the issue is that they have to be some place we don't mind adding a dependency on 'Job' from...
Comment 4 Remy Suen CLA 2011-09-29 09:14:50 EDT 
(In reply to comment #3)
> IIRC the issue is that they have to be some place we don't mind adding a
> dependency on 'Job' from...

Both org.eclipse.e4.ui.workbench and org.eclipse.e4.ui.workbench.swt have a dependency on the org.eclipse.core.jobs bundle.
Comment 5 Eric Moffatt CLA 2011-09-29 16:02:44 EDT 
I guess ...workbench.swt makes the most sense since the code is SWT dependent...
Comment 6 Eric Moffatt CLA 2011-12-08 10:02:30 EST 
Moving to M5...we should clone the code over to some e4 bundle and make the necessary adjustments to the MinMaxAddon...
Comment 7 Eric Moffatt CLA 2012-01-04 10:53:28 EST 
Pushed in >20120104.

commit b89263ff83f52392a97608837007d589cd92059e
Comment 8 Eric Moffatt CLA 2012-01-24 13:44:24 EST 
Verified in I20120123-2200.