Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358732 - [Model Explorer] Make the model explorer view fully implemented with EMF Facet
Summary: [Model Explorer] Make the model explorer view fully implemented with EMF Facet
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 335424 (view as bug list)
Depends on: 359691 359692 359793 360081
Blocks:
  Show dependency tree
 
Reported: 2011-09-23 10:45 EDT by Arthur Daussy CLA
Modified: 2013-02-07 04:20 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Daussy CLA 2011-09-23 10:45:12 EDT 
I'm currently trying to make the Model Explorer View fully functional with EMF Facet. For now, only UML elements display use EMF Facet. However diagrams are displayed with a custom IContentProvider. So I would like the diagrams to be display with EMF Facet. 
To do that I going to use the "Facet" part of EMF Facet. That is to say, add a "virtual" reference on some UML elements which would references the diagrams they contain.

This is for now just a try so if anyone has some ideas this topic is open to discussion.

(This refactoring has been needed after some work on "Collaborative work" in MDT Papyrus).
Comment 1 Arthur Daussy CLA 2011-09-26 12:49:13 EDT 
*** Bug 335424 has been marked as a duplicate of this bug. ***
Comment 2 Arthur Daussy CLA 2011-09-26 13:02:17 EDT 
Coming soon...
Comment 3 Arthur Daussy CLA 2011-09-27 02:58:59 EDT 
To do so the following changes would be necessary in the code:
	-> In org.eclipse.papyrus.core:
		Changes in the EditorIcons mechanism. It's now possible to get the URI of an icon provided by MDT Papyrus
	-> In org.eclipse.model.explorer
		Change in the double click listener (to correct the bug 335424)
		Change in the ContentProvider. The diagram will not be handled as children of UML element (virtually added by the content provider). This relation will be now represented by a facet.
	-> In org.eclipse.papyrus.uml.modelexplorer
		Customization on the facet:
			-> Customization of notation.diagram elements
			-> Customization of the faceted elements
Comment 4 Arthur Daussy CLA 2011-09-27 04:35:54 EDT 
To do so the following changes would be necessary in the code:
	-> The property tester isDiagram will now return yes if the element is an IAdaptable of Diagram
	-> The Abstract Common Handler will now handle IAfaptable element
Comment 5 Arthur Daussy CLA 2011-09-28 08:05:38 EDT 
The correction of this bug was committed on the:
	-> trunk - Commit number : 5608
	-> branch 0.8.X - Commit number :  5600
Comment 6 Vincent Lorenzo CLA 2011-10-05 10:38:14 EDT 
In R5714 (branch) and R5715(trunk) : refactoring on oep.uml.modelexplorer to avoid duplicated code between this plugin and oep.table.modelexplorer.
Comment 7 Camille Letavernier CLA 2011-10-05 11:18:03 EDT 
Hello,

The oep.uml.modelexplorer.queries.IsReadOnly query is not totally satisfying, as it brings a regression.

When you browse a UML Model directly from the Project Explorer, the model isn't opened in an Editor, and doesn't have an EditingDomain. When the isReadOnly query is called, it throws an exception.

This query should probably return a default value when the UML Element doesn't have an Editing Domain (I don't really know if it should be true or false...)

The problem doesn't seem to occur with the other queries.
Comment 8 Arthur Daussy CLA 2011-10-06 05:07:57 EDT 
I'm looking into it today.
Comment 9 Mathieu Velten CLA 2011-10-06 05:25:07 EDT 
fixed and commited (branch only, I didn't have the time to backport the whole commandStack/read-only thing to trunk yet).
Comment 10 Vincent Lorenzo CLA 2011-11-07 03:11:45 EST 
In R6008 & R6191 : change the query getContainedDiagrams into GetContainedDiagrams.
Comment 11 Vincent Lorenzo CLA 2011-11-15 11:24:48 EST 
In R6247 : Undo the previous classpath modification, in order to compile correctly the query GetOwnedDiagrams.
Comment 12 Vincent Lorenzo CLA 2011-11-24 07:14:32 EST 
In R6282 : modify the queries in order to avoid an Exception, when the queries are loaded in a context which is not a Papyrus Context.
Comment 13 Vincent Lorenzo CLA 2011-11-24 07:27:14 EST 
In R6283 : remove unused dependencies
Comment 14 Vincent Lorenzo CLA 2011-11-24 08:09:00 EST 
Merge with trunk in R6286
Comment 15 Vincent Lorenzo CLA 2013-02-07 04:20:41 EST 
I suppose that this bug can be marked as closed fixed. If you don't agree, don't hesitate to reopen it.