Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358727 - Improve performance of StateBasedContainer.filterByURI
Summary: Improve performance of StateBasedContainer.filterByURI
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: SR2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 10:15 EDT by Lieven Lemiengre CLA
Modified: 2017-09-19 17:33 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
patch (3.07 KB, patch)
2011-09-23 10:15 EDT, Lieven Lemiengre CLA 		sven.efftinge: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lieven Lemiengre CLA 2011-09-23 10:15:58 EDT 
Created attachment 203907 [details]
patch

This patch improves the build performance when multiple projects depend on eachother.

In StateBasedContainer, the methodcall IContainerState.getContents() is expensive so I've cached the result.

In ResourceDescriptionsBasedContainer the filter can be eliminated because hasResourceDescription(URI) is always true.
Comment 1 Sebastian Zarnekow CLA 2011-09-27 05:35:13 EDT 
Scheduled for review
Comment 2 Sebastian Zarnekow CLA 2011-10-09 12:25:47 EDT 
Patch looks good. Pushed to master.

Thanks, Lieven.
Comment 3 Karsten Thoms CLA 2017-09-19 17:22:33 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 4 Karsten Thoms CLA 2017-09-19 17:33:58 EDT 
Closing all bugs that were set to RESOLVED before Neon.0