Community
Participate
Working Groups
Build Identifier: I did not find it intuitive that the popup would close when you click on the month arrows. I have fixed this so that if the arrowThread was running when the mouseUp event is received, we will not close the popup. This happens if you have a date selected (which was most likely from before you clicked on the arrow). Reproducible: Always Steps to Reproduce: 1.drop down the combo to show the calendar 2.click on the arrow key (either direction) 3.upon mouse up, popup closes (if you had a previously selected date)
Created attachment 203906 [details] patch for mouse click processing of arrow buttons on month bar (and includes key processing fix from previously submitted patch)
Code to just fix the mouse processing is below. From CalendarComposite.java: public void mouseUp(MouseEvent event) { mMouseIsDown = false; boolean bArrowThread = (mArrowThread!=null); killArrowThread(); if (mNoDayClicked) { mNoDayClicked = false; return; } if (mDateRange) { // this may seem odd but it's not. First we set the "up" date to the // current date // then we overwrite it by setting the selected date to when the // mouse click was "down". // that way the date set on the combo will be the date the user // clicked first, and not the date when the user // let go of the mouse button, this will be reflected in the // listeners as well mMouseUpDay = mSelectedDay; mSelectedDay = mMouseDownDay; } //don't close the popup if they were pressing the arrow! if (mSelectedDay != null && !bArrowThread) { notifyListeners(); notifyClose(); } }
Patch applies, thanks!!
