Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358722 - Fast views close when tree is traversed
Summary: Fast views close when tree is traversed
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Dean Roberts CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 358439
Blocks:
  Show dependency tree
 
Reported: 2011-09-23 09:52 EDT by Dean Roberts CLA
Modified: 2011-10-26 14:09 EDT (History)
2 users (show)

See Also:

Attachments
Fix over aggressive closing of fast views (9.18 KB, patch)
2011-09-23 10:01 EDT, Dean Roberts CLA 		no flags Details | Diff
Better patch for this problem. (8.20 KB, patch)
2011-09-23 16:31 EDT, Dean Roberts CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2011-09-23 09:52:51 EDT 
1) Open a java file so that an out liner has content
2) Minimize the outliner
3) Open the outliner fast view
4) Use the keyboard to move up or down the outline list

Notice that the outline closes

This is a result of the TrimStack close handler listening to BringToTop events, it should instead listen to Activation events.
Comment 1 Dean Roberts CLA 2011-09-23 10:01:40 EDT 
Created attachment 203902 [details]
Fix over aggressive closing of fast views

This patch adds publish methods to UIEvents.  As such you must add the patch from the depends on bug first.
Comment 2 Dean Roberts CLA 2011-09-23 16:31:48 EDT 
Created attachment 203941 [details]
Better patch for this problem.

This is probably a better patch for this defect.  Reworked parameters for UIEvents.publish methods do reduce the amount of knowledge and code needed by callers.
Comment 3 Eric Moffatt CLA 2011-09-27 14:01:19 EDT 
Pushed in >20110927.

commit 44161b37a31390958fc4cb23fdd1c4f77ea42d48

Nice one Dean !
Comment 4 Remy Suen CLA 2011-09-27 14:17:27 EDT 
(In reply to comment #3)
> Pushed in >20110927.
> 
> commit 44161b37a31390958fc4cb23fdd1c4f77ea42d48

I had to push another fix to origin due to use of Java 6 APIs that were causing compiler errors on my computer.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=72b9d682d27ec0c5f6b655f436dd2d6c907b49e7

Eric and Dean, please ensure you have Java 5 setup in your workspace to prevent this in the future.
Comment 5 Remy Suen CLA 2011-09-29 10:24:01 EDT 
(In reply to comment #3)
> Pushed in >20110927.
> 
> commit 44161b37a31390958fc4cb23fdd1c4f77ea42d48

Can we close this?
Comment 6 Eric Moffatt CLA 2011-09-29 15:57:29 EDT 
Seems like it...
Comment 7 Eric Moffatt CLA 2011-10-26 14:09:33 EDT 
Verified in I20111025-2000.