Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358659 - REST binding browse button returns the wrong value
Summary: REST binding browse button returns the wrong value
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tony Chen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 16:16 EDT by Joseph Vincens CLA
Modified: 2017-02-23 14:15 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Vincens CLA 2011-09-22 16:16:01 EDT 
In the egldd editor Resource Binding tab.
After pressing add REST there is a browse button that returns an interface or service type. In EDT the resource binding name is no longer a Part name it's a variable name see 358310 and 358309.
It would be best to just remove the button and let the user enter a name. The name will need to be a valid EGL identifier.
Comment 1 Justin Spadea CLA 2011-09-23 09:17:45 EDT 
Joe - can the user specify anything they want (spaces, slashes, etc) for the bindingKey property of @Resource? If so then we should not prevent such characters from being manually entered. I think that we should only remove invalid identifier characters when we default the binding name (like with the SQL binding wizard).
Comment 2 Joseph Vincens CLA 2011-09-23 09:25:09 EDT 
Justin is correct, if the user wants to use @Resource{bindingKey="mm nn%@/"} that is legal so we should not add any validation to this page, we should simply remove the button.
Comment 3 Justin Spadea CLA 2011-10-03 16:47:46 EDT 
The browse button has been removed, and we also now validate that the binding name is not blank. Modified:

NewWizardMessages.java
NewWizardMessages.properties
RestBindingWizardPage.java
Comment 4 Joseph Vincens CLA 2011-10-24 16:35:59 EDT 
verified
Comment 5 Joseph Vincens CLA 2011-10-24 16:36:46 EDT 
verified