This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 358644 - [patch] Remove from context popup appears where it shouldn't
Summary: [patch] Remove from context popup appears where it shouldn't
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 357747
  Show dependency tree
 
Reported: 2011-09-22 14:23 EDT by Miles Parker CLA
Modified: 2012-09-15 21:59 EDT (History)
2 users (show)

See Also:

Attachments
Simple patch for plugin.xml (381 bytes, patch)
2011-09-22 19:18 EDT, Miles Parker CLA 		no flags Details | Diff
mylyn/context/zip (3.43 KB, application/octet-stream)
2011-09-22 19:18 EDT, Miles Parker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2011-09-22 14:23:52 EDT 
In workbench parts that adapt to the underlying resource such as ecore and GMF editors the "Remove from Context" popup is available. This is a problem for two reasons:

1. When the user clicks "remove from context" the entire editor is closed, which is probably not what the user expected.
2. Other Mylyn implementors (such as Mylyn for modeling, see dependent bug) are not able to provide finer grained context removal using the same definitions and labels.
Comment 1 Miles Parker CLA 2011-09-22 14:29:14 EDT 
The following (very simple!) patch fixes the issue by setting the adapt flag to false, just as it is for mark as landmark. I don't know if this will break some other intended behavior, that is why this was adapting in the first place. Also, note that org.eclipse.mylyn.internal.context.ui.actions.InterestDecrementAction referes to IRersource whereas org.eclipse.mylyn.internal.context.ui.actions.InterestIncrementAction refers to IFile. I don't know if that makes a difference in practice or if there is a reason for that.
Comment 2 Steffen Pingel CLA 2011-09-22 17:28:45 EDT 
Can you attach the patch? Thanks!
Comment 3 Miles Parker CLA 2011-09-22 19:18:11 EDT 
Created attachment 203874 [details]
Simple patch for plugin.xml
Comment 4 Miles Parker CLA 2011-09-22 19:18:13 EDT 
Created attachment 203875 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-09-23 04:40:03 EDT 
Seems likely that we would loose the contribution from places like editor context menus. Given that this contribution makes it more difficult to scope the remove from context action to specific elements in editors I wonder if it's reasonable to make the suggested change. Shawn?
Comment 6 Miles Parker CLA 2011-09-23 20:11:29 EDT 
(In reply to comment #5)
> Seems likely that we would loose the contribution from places like editor
> context menus.

Yeah, that's precisely the issue. :) Do you mean less difficult? The problem right now is that I was unable to find a way to get the context menu to *not* show up when the user selects elements w/in editors.
Comment 7 Miles Parker CLA 2012-08-27 18:47:57 EDT 
Ping. Are we going to do this or is it a WONTFIX? Just wanting to resolve the dependent bug if possible.
Comment 8 Steffen Pingel CLA 2012-09-03 23:57:38 EDT 
Let's discuss on the next call how to proceed. Another somewhat related bug is here: 

bug 387156: Allow editor actions to obtain current context
https://bugs.eclipse.org/bugs/show_bug.cgi?id=387156
Comment 9 Steffen Pingel CLA 2012-09-15 21:59:32 EDT 
Shawn, can you take a look at this bug when you get a chance?
Comment 10 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn