Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358617 - new icons for 0.3
Summary: new icons for 0.3
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 12:00 EDT by Susan McCourt CLA
Modified: 2011-10-03 12:00 EDT (History)
6 users (show)

See Also:


Attachments
eclipse error/warning icon (577 bytes, image/gif)
2011-09-26 13:20 EDT, Susan McCourt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-09-22 12:00:28 EDT
We need some new icons for 0.3

Find/Replace Bar - Replace
Find/Replace Bar - Replace All
Search Results Page - Collapse All
Search Results Page - Result  (currently using the incoming arrow)
Sites - Start  
Sites - Stop
Sites - Edit 

Are there any others?
Comment 1 Felipe Heidrich CLA 2011-09-22 12:27:20 EDT
(In reply to comment #0)
> Are there any others?

for the annotaion rulers:
error,
warnings,
bookmark (future),
todo (future),
multiple annotation - when a line mixes errors, warnings, bookmark, etc - Eclipse draws the images overlapping each other, in Orion we have an icon for that.

(Personally I think that error and warnings icons are fine)
Comment 2 Susan McCourt CLA 2011-09-22 12:46:31 EDT
(In reply to comment #1)
> for the annotaion rulers:
> error,
> warnings,
> bookmark (future),
> todo (future),
> multiple annotation - when a line mixes errors, warnings, bookmark, etc -
> Eclipse draws the images overlapping each other, in Orion we have an icon for
> that.
> 
> (Personally I think that error and warnings icons are fine)

I do, too, since their whole purpose is to get your attention, I think using colors here is appropriate (vs. trying to go the yellow route).

So I think for 0.3 we just keep what we have for those, and continue to pull the eclipse icons for bookmark, todo, etc.

Do we have the "mixing annotations" problem in 0.3?
Comment 3 Mark Macdonald CLA 2011-09-22 13:42:59 EDT
If we really want to go wild with new icons, there's also Bug 355877.
Comment 4 libing wang CLA 2011-09-22 16:16:38 EDT
3 more :
Search result page:
Refresh 
Expand All
Rerun search
Comment 5 libing wang CLA 2011-09-22 16:17:21 EDT
(In reply to comment #4)
> 3 more :
> Search result page:
> Refresh 
> Expand All
> Rerun search

Please ignore "Refresh" , it was a typo.
Comment 6 Felipe Heidrich CLA 2011-09-22 16:27:20 EDT
(In reply to comment #2)
> Do we have the "mixing annotations" problem in 0.3?

yes, you can have warnings and errors on the same line.
(the annotation ruler will show only the first annotation img)

Note that the case "several annotation of the same type on a line", like several errors on the same line, is handle by the ruler already. It draws the image for the annotation with a little plus over it on the right-bottom corner.
Comment 7 Susan McCourt CLA 2011-09-23 15:44:42 EDT
(In reply to comment #3)
> If we really want to go wild with new icons, there's also Bug 355877.

Not feeling wild for 0.3, but I did mark that bug 0.4.
Comment 8 Susan McCourt CLA 2011-09-26 13:19:51 EDT
Submitted request to graphic designer for:

1. Search Results - expand all
2. Search Results - collapse all
3. Find/Replace - replace
4. Find/Replace - replace all
5. Sites - edit
6. Sites - start
7. Sites - stop

Did not submit requests for:
- Search Results - result.  The eclipse metaphor is an arrow pointing right, so we should just use the arrow pointing right rather than pointing left
- Search Results - rerun search.  Libing and I discussed using page reload for this rather than introducing an icon.
- Warning - we are happy with eclipse one
- Error - we are happy with eclipse one
- Bookmark - grab eclipse one
- Todo - grab eclipse one
- Mixed error/warning - attaching existing eclipse icon.  Once we have more annotations in the future we may want to get something different designed, but this will work for 0.3
Comment 9 Susan McCourt CLA 2011-09-26 13:20:34 EDT
Created attachment 204025 [details]
eclipse error/warning icon

Felipe, can you add this as needed to the editor annotation code?
Comment 10 Susan McCourt CLA 2011-10-03 12:00:55 EDT
new icons have been added/replaced and references updated.

(Felipe, I did not do the mixed annotation marker, but the icon is still attached here in this bug.)