Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358581 - AbstractCDOView.getObjectsArray gives array with NULLs
Summary: AbstractCDOView.getObjectsArray gives array with NULLs
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Egidijus Vaisnora CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 09:17 EDT by Egidijus Vaisnora CLA
Modified: 2012-09-21 07:18 EDT (History)
1 user (show)

See Also:
stepper: review+


Attachments
Test case (2.64 KB, patch)
2011-09-22 09:21 EDT, Egidijus Vaisnora CLA
no flags Details | Diff
Patch v1 (1.45 KB, patch)
2011-09-22 11:10 EDT, Egidijus Vaisnora CLA
no flags Details | Diff
Patch v2 (1.47 KB, patch)
2011-09-22 12:06 EDT, Egidijus Vaisnora CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-09-22 09:17:36 EDT
AbstractCDOView.getObjectsArray can occasionally return NULL values. Seems that this is the case when GC is removing from ReferenceValueMap and at the same time AbstractCDOView.getObjectsArray constructs an array to return.
Comment 1 Egidijus Vaisnora CLA 2011-09-22 09:21:38 EDT
Created attachment 203839 [details]
Test case

simple test case which illustrate situation. Note, that with debuging mode I cannot reproduce it.
Comment 2 Egidijus Vaisnora CLA 2011-09-22 11:10:05 EDT
Created attachment 203847 [details]
Patch v1

Patch doesn't include test case, because test case cannot always reflect bug
Comment 3 Egidijus Vaisnora CLA 2011-09-22 12:06:01 EDT
Created attachment 203849 [details]
Patch v2
Comment 4 Egidijus Vaisnora CLA 2011-09-23 05:29:50 EDT
Committed revision 9223, trunk
Comment 5 Eike Stepper CLA 2011-09-23 06:19:37 EDT
I've renamed getObjectsArray() to getObjectsList() and changed the logic accordingly.

Committed revision 9224
Comment 6 Eike Stepper CLA 2012-09-21 07:18:42 EDT
Closing.