Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358534 - GitProjectSetCapability swallows exceptions (InvocationTargetException)
Summary: GitProjectSetCapability swallows exceptions (InvocationTargetException)
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 04:56 EDT by GianMaria Romanato CLA
Modified: 2011-09-30 12:00 EDT (History)
2 users (show)

See Also:

Attachments
A proposed patch (1011 bytes, patch)
2011-09-22 04:56 EDT, GianMaria Romanato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description GianMaria Romanato CLA 2011-09-22 04:56:33 EDT 
Build Identifier: 1.1.0.201109151100-r

The current implementation of addToWorkspace method catches InvocationTargetException and throws a team exception without unboxing the original exception, therefore loosing details about the original problem

Reproducible: Always

Steps to Reproduce:
1. perform a clone that makes CloneOperation.run throw an InvocationTargetException
2. the raised TeamException looses detail about the original exception
Comment 1 GianMaria Romanato CLA 2011-09-22 04:56:58 EDT 
Created attachment 203824 [details]
A proposed patch
Comment 2 Matthias Sohn CLA 2011-09-29 07:39:40 EDT 
Could you push this patch to our code review server as described in the EGit Contributor Guide [1] ?

[1] http://wiki.eclipse.org/EGit/Contributor_Guide
Comment 3 GianMaria Romanato CLA 2011-09-29 11:45:55 EDT 
My colleague Renato registered to gerrit and pushed a cumulative patch for this defect and for defect #358530.

As this is the first time we used gerrit, please double check we did not make any mistake.
Thanks.
Comment 4 Jens Baumgart CLA 2011-09-30 12:00:54 EDT 
Fixed with commit 9953f30844f843a7dc57ac42468ea2106e12f873