Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358500 - org.eclipse.linuxtools.rpmstubby should not require PDE
Summary: org.eclipse.linuxtools.rpmstubby should not require PDE
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: RPM (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 18:53 EDT by Severin Gehwolf CLA
Modified: 2011-09-22 04:28 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Severin Gehwolf CLA 2011-09-21 18:53:50 EDT 
Judging from the code it does not look like there is a formal dependency of RPMStubby on PDE. This (seemingly) incorrect dependency seems to be a problem, since RPMStubby does not resolve without having PDE installed. Am I missing something here?

If I'm right, feel free to cherry-pick the following commit:
https://github.com/jerboaa/linuxtools/commit/86f64f8422892107744d9e018ce080085faeec0d

Thanks!
Comment 1 Severin Gehwolf CLA 2011-09-21 18:56:10 EDT 
Here is the log output of rpmstubby not resolving with PDE not installed:

!ENTRY org.eclipse.osgi 2 0 2011-09-21 18:14:34.409
!MESSAGE One or more bundles are not resolved because the following root constraints are not resolved:
!SUBENTRY 1 org.eclipse.osgi 2 0 2011-09-21 18:14:34.410
!MESSAGE Bundle reference:file:../../share/eclipse/dropins/rpmstubby/eclipse/plugins/org.eclipse.linuxtools.rpmstubby_0.3.0.201108151400.jar was not resolved.
!SUBENTRY 2 org.eclipse.linuxtools.rpmstubby 2 0 2011-09-21 18:14:34.411
!MESSAGE Missing required bundle org.eclipse.pde.core_0.0.0.

!ENTRY org.eclipse.osgi 2 0 2011-09-21 18:14:34.480
!MESSAGE The following is a complete list of bundles which are not resolved, see the prior log entry for the root cause if it exists:
!SUBENTRY 1 org.eclipse.osgi 2 0 2011-09-21 18:14:34.480
!MESSAGE Bundle org.eclipse.linuxtools.rpmstubby_0.3.0.201108151400 [203] was not resolved.
!SUBENTRY 2 org.eclipse.linuxtools.rpmstubby 2 0 2011-09-21 18:14:34.480
!MESSAGE Missing required bundle org.eclipse.pde.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi 2 0 2011-09-21 18:14:34.481
Comment 2 Alexander Kurtakov CLA 2011-09-22 04:28:29 EDT 
Good catch. It's really not needed anymore. 
Fixed together with other things in e2bd95f..681e714