Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358398 - Fix (FindBugs) warnings in UniversalUniqueIdentifier
Summary: Fix (FindBugs) warnings in UniversalUniqueIdentifier
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 0.3 M2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 07:43 EDT by Tomasz Zarna CLA
Modified: 2011-09-21 07:45 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-09-21 07:43:17 EDT 
Non-externalized string literal >> it should be followed by //$NON-NLS-<n>$

Warnings reported by FindBugs:

* Method org.eclipse.orion.server.core.resources.UniversalUniqueIdentifier.toStringAsBytes() concatenates strings using + in a loop >> Better performance can be obtained by using a StringBuffer (or StringBuilder in Java 1.5) explicitly.
* org.eclipse.orion.server.core.resources.UniversalUniqueIdentifier.computeNodeAddress() invokes inefficient new String() constructor >> Use the empty string constant directly
* Method org.eclipse.orion.server.core.resources.UniversalUniqueIdentifier.nextClockSequence() uses the nextDouble method of Random to generate a random integer >> Using nextInt is more efficient