Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358280 - "Remove Repository from View" dialog proceeds on Esc
Summary: "Remove Repository from View" dialog proceeds on Esc
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 13:47 EDT by Markus Keller CLA
Modified: 2011-09-22 04:14 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-09-20 13:47:39 EDT 
1.1.0.201109151100

In the Git Repositories view, the "Remove Repository from View" command shows a "Confirm Project Deletion" MessageDialog if the workspace contains shared projects from that repository.

When I press Esc or click the close box in this dialog, the repository is removed. Esc should always mean "Cancel".

Implementation detail: MessageDialog#open() returns SWT.DEFAULT if none of the buttons has been pressed. This has always been like this, but the Javadoc only tells it explicitly since 3.5.
Comment 1 Kevin Sawicki CLA 2011-09-20 16:30:22 EDT 
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4274
Comment 2 Matthias Sohn CLA 2011-09-22 04:14:25 EDT 
merged as fd140918c8ff9d59cfebea1eb21498ec7f6f4606