Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358245 - GitQuickDiffProvider.isEnabled() not correctly implemented - breaks Quick Diff
Summary: GitQuickDiffProvider.isEnabled() not correctly implemented - breaks Quick Diff
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 09:43 EDT by Dani Megert CLA
Modified: 2011-10-04 04:24 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-09-20 09:43:00 EDT 
1.1.0.201109151100-r.

GitQuickDiffProvider.isEnabled() must not return 'true' for files coming from a project that isn't shared with Git.

Quick Diff tries to find an alternative to the default Quick Diff provider if a provider can't handle a certain case (mostly because the file is not shared with the corresponding team provider).

Test Case:
1. set Git as reference provider ('Quick Diff' preference page)
2. create a local project and add a file
3. open the file and start typing
==> changes are not shown in ruler.
Comment 1 Remy Suen CLA 2011-09-20 18:01:30 EDT 
A change set has been pushed to Gerrit for review.
http://egit.eclipse.org/r/#change,4275
Comment 2 Matthias Sohn CLA 2011-09-22 04:27:00 EDT 
merged as 5f94ddcb333be6c3be1ee56aee5c105cdb744c25
Comment 3 Dani Megert CLA 2011-10-04 04:24:43 EDT 
Verified in 1.2.0.201110021920.