Community
Participate
Working Groups
Build Identifier: Replace the existing UTF8Appendable.java with the algorithm from Bjoern Hoehrmann described here: http://bjoern.hoehrmann.de/utf-8/decoder/dfa/ Measure the performance differences and add Unit tests for invalid UTF8 chars. Reproducible: Always
Created attachment 203595 [details] Patch files Tar archive containing git patch files.
Thomas, the patch file is a little strange... it appears to have the complete history of the development of the change. It would be best to get just a diff from trunk to the new code rather than the intermediary steps. Also, I think you need to do more with regards to the copy right. If you read the dfa page you will see a license statement that says: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. So can you make sure you have the full license in the file.
The patch includes a single file per commit. That's ok and intended, so you keep the whole change history. If I do an individual commit for a code format for example, it's necessary to keep it separated from other commits. However the patch is broken as I didn't have a clean copy of origin/master, but my local master copy of the git repo including some changes from another patch. I've redone the whole patch based on trunk and will attach the new patch file in a minute. I also added the full copyright notice now.
Created attachment 203673 [details] proposed patch New patch file based on origin/master
Patch reviewed and applied.
