Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358113 - MAT stand-alone packages include junit
Summary: MAT stand-alone packages include junit
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: Core (show other bugs)
Version: 1.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 09:07 EDT by Krum Tsvetkov CLA
Modified: 2011-11-11 09:33 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Krum Tsvetkov CLA 2011-09-19 09:07:04 EDT
MAT products built with Tycho include junit. This istn't needed for MAT itself.
We should check from where it comes as a dependency, and if it is an optional one - to exclude it.
Comment 1 Andrew Johnson CLA 2011-11-09 03:42:43 EST
These are the junit plugins:
<plugin
      id="org.hamcrest.core"
      download-size="0"
      install-size="0"
      version="0.0.0"
      unpack="false"/>
<plugin
      id="org.junit"
      download-size="0"
      install-size="0"
      version="0.0.0"/>
<plugin
      id="org.junit4"
      download-size="0"
      install-size="0"
      version="0.0.0"/>

Could we move them to the o.e.mat.test.feature or have a separate test.dependencies.feature?
Comment 2 Andrew Johnson CLA 2011-11-10 11:57:48 EST
Try moving ant, junit, junit4, hamcrest from dependencies to the test feature.
Comment 3 Andrew Johnson CLA 2011-11-11 09:16:49 EST
org.apache.ant is needed, as shown by the Eclipse bundle explorer on a dump from MAT itself,
I'll put org.apache.ant back into dependencies.feature, org.eclipse.ant.optional.junit can remain test.feature. A build does work without org.apache.ant in dependencies.feature as it gets pulled into the RCP somehow.

Bundles                                                                                                                                                                            |Bundle State
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
org.apache.ant ( 1.7.1.v20100518-1145)                                                                                                                                             |resolved
|- /C:/Users/IBM_ADMIN/Documents/move/m5/org.eclipse.mat.ui.rcp.MemoryAnalyzer-win32.win32.x86_64/mat/plugins/org.apache.ant_1.7.1.v20100518-1145/                                 |
|- Dependencies                                                                                                                                                                    |
|- Dependents                                                                                                                                                                      |
|  '- org.apache.jasper ( 5.5.17.v201004212143)                                                                                                                                    |resolved
|     |- /C:/Users/IBM_ADMIN/Documents/move/m5/org.eclipse.mat.ui.rcp.MemoryAnalyzer-win32.win32.x86_64/mat/plugins/org.apache.jasper_5.5.17.v201004212143.jar                     |
|     |- Dependencies                                                                                                                                                              |
|     |- Dependents                                                                                                                                                                |
|     |  |- org.eclipse.equinox.jsp.jasper ( 1.0.201.R36x_v20101103)                                                                                                               |active
|     |  |- org.eclipse.help.webapp ( 3.5.3.r36_20101130)                                                                                                                          |active
|     |  |- org.mortbay.jetty.server ( 6.1.23.v201004211559)                                                                                                                       |resolved
|     |  |  |- /C:/Users/IBM_ADMIN/Documents/move/m5/org.eclipse.mat.ui.rcp.MemoryAnalyzer-win32.win32.x86_64/mat/plugins/org.mortbay.jetty.server_6.1.23.v201004211559.jar        |
|     |  |  |- Dependencies                                                                                                                                                        |
|     |  |  |- Dependents                                                                                                                                                          |
|     |  |  |  '- org.eclipse.equinox.http.jetty ( 2.0.0.v20100503)                                                                                                                |active
|     |  |  |     |- /C:/Users/IBM_ADMIN/Documents/move/m5/org.eclipse.mat.ui.rcp.MemoryAnalyzer-win32.win32.x86_64/mat/plugins/org.eclipse.equinox.http.jetty_2.0.0.v20100503.jar |
|     |  |  |     |- Dependencies                                                                                                                                                  |
|     |  |  |     |- Dependents                                                                                                                                                    |
|     |  |  |     |  '- org.eclipse.help.base ( 3.5.3.v201102101200)                                                                                                               |active
|     |  |  |     |     |- /C:/Users/IBM_ADMIN/Documents/move/m5/org.eclipse.mat.ui.rcp.MemoryAnalyzer-win32.win32.x86_64/mat/plugins/org.eclipse.help.base_3.5.3.v201102101200.jar|
|     |  |  |     |     |- Dependencies                                                                                                                                            |
|     |  |  |     |     |- Dependents                                                                                                                                              |
|     |  |  |     |     |  |- org.eclipse.mat.ui.rcp ( 1.1.1.201111111233)                                                                                                         |active
|     |  |  |     |     |  |- org.eclipse.ui.cheatsheets ( 3.4.0.v20100427)                                                                                                        |active
|     |  |  |     |     |  |- org.eclipse.mat.ui.help ( 1.1.1.201111111233)                                                                                                        |resolved
|     |  |  |     |     |  |- org.eclipse.help.ui ( 3.5.3.r36_20101116)                                                                                                            |active
|     |  |  |     |     |  |- org.eclipse.ui.intro ( 3.4.0.v20100427)                                                                                                              |active
|     |  |  |     |     |  |- org.eclipse.help.webapp ( 3.5.3.r36_20101130)                                                                                                        |active
|     |  |  |     |     |  '- Total: 6 entries                                                                                                                                     |
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Comment 4 Andrew Johnson CLA 2011-11-11 09:33:35 EST
Moved plugins are:

org.hamcrest.core
org.junit
org.junit4
org.eclipse.ant.optional.junit