Description Simon Kaegi 2011-09-15 17:56:13 EDT

While looking at a problem with Libing we noticed a number of coding errors in how prototype's are being used.

The coding pattern below will actually alter the parent prototype instead of creating a copy.

Instead of assigning from the prototype one should create a new instance.

In org.eclipse.orion.client.core/web/orion:
editorCommands.js
169: KB.prototype = mKeyBinding.KeyBinding.prototype; 

explorer-table.js (3 matches)
26: Model.prototype = mExplorer.ExplorerModel.prototype;  
60: FileRenderer.prototype = mExplorer.SelectionRenderer.prototype;  
156: FileExplorer.prototype = mExplorer.Explorer.prototype; 

In org.eclipse.orion.client.git/web/orion/git:
git-clones-explorer.js (3 matches)
34: GitClonesExplorer.prototype = mExplorer.Explorer.prototype; 
105: GitClonesModel.prototype = mExplorer.ExplorerModel.prototype;  
194: GitClonesRenderer.prototype = mExplorer.SelectionRenderer.prototype; 

git-commit-navigator.js
117: GitCommitRenderer.prototype = mExplorer.SelectionRenderer.prototype; 


In org.eclipse.orion.client.users.ui/web/orion/profile
UsersList.js (2 matches)
29: UsersList.prototype = mExplorer.Explorer.prototype; 
66: UsersRenderer.prototype = mExplorer.SelectionRenderer.prototype;