Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357878 - canAddBendpoint() = false has strange behaviour
Summary: canAddBendpoint() = false has strange behaviour
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Tim Kaiser CLA
QA Contact:
URL:
Whiteboard: Juno M3 theme_bugs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 16:25 EDT by Hernan Gonzalez CLA
Modified: 2012-06-28 10:47 EDT (History)
2 users (show)

See Also:
tim.kaiser: juno+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hernan Gonzalez CLA 2011-09-15 16:25:19 EDT
This can be reproduced by simply coding 

	public boolean canAddBendpoint(IAddBendpointContext context) {
		return false;
        }

in our AddBendpointFeature, e.g. in the Tutorial. When one selects a FreeFormConnection and tries to manipulate it adding and moving several
bendpoints, the method canAddBendpoint() is indeed called, but the user has no visual feedback, it seems that the bendpoints are correctly added, they can be moved, etc. Only when one clicks outside the connection, to deselect it, the phantom bendpoints disappear and the connection returns to its original shape.
Comment 1 Tim Kaiser CLA 2011-09-28 10:00:45 EDT
Added a refresh in ConnectionBendPointEditpolicy.
This updates the connection's edit part after an erasure
of source feedback. This brings the desired effect of snapping back
if the addition of the bend point is not possible.

Also two deprecation warnings were removed and the respective algorithm improved.
Comment 2 Michael Wenz CLA 2011-09-28 10:09:35 EDT
Part of M3, not M2
Comment 3 Michael Wenz CLA 2012-04-11 10:42:31 EDT
Bookkeeping: Set target release
Comment 4 Michael Wenz CLA 2012-06-28 10:47:08 EDT
Part of Graphiti 0.9.0 (Eclipse Juno)