Bug 357875 – Saving a perspective with a minimized part stack leaves it behind when closed

Bug 357875 - Saving a perspective with a minimized part stack leaves it behind when closed


Summary:	Saving a perspective with a minimized part stack leaves it behind when closed

Status:	VERIFIED FIXED

Product:	Platform
Classification:	Eclipse
Component:	UI
Version:	4.2
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	4.2 M3
Assigned To:	Dean Roberts
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-09-15 16:12 EDT by Remy Suen
Modified:	2011-10-26 13:44 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch to adjust TrimStack ids when perspective id changes (6.62 KB, patch) 2011-09-22 08:37 EDT, Dean Roberts	no flags	Details \| Diff
Fix warnings in MinMaxAddon.java (1.83 KB, patch) 2011-09-22 09:27 EDT, Dean Roberts	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Remy Suen

2011-09-15 16:12:05 EDT

I20110914-0200

1. Minimize a part stack.
2. Save the perspective.
3. Open another perspective.
4. The previously minimized part stack is still in the trim stack.

Comment 1 Dean Roberts

2011-09-16 09:15:13 EDT

Also, the saved perspective looses the TrimStack

Comment 2 Dean Roberts

2011-09-22 08:37:36 EDT

Created attachment 203837 [details]
Patch to adjust TrimStack ids when perspective id changes

Comment 3 Dean Roberts

2011-09-22 09:27:07 EDT

Created attachment 203840 [details]
Fix warnings in MinMaxAddon.java

Here is a patch that fixes the warnings (that where pre existing) in MinMaxAddon.java.

This patch should be applied after the 1st patch on this defect, which actually fixes the problem.

I would suggest that these patches be done in two commits so that we can clearly see the fix code.

Unfortunately, on of the files needed to fix MinMaxAddOn itself has warnings ... but I don't have enough information yet to fix it :-)  Email sent about that one.

Comment 4 Eric Moffatt

2011-09-23 11:32:16 EDT

Pushed in >20110923.

commit 092854683ee2e043949f8e72717872cb4610aaeb

Dean, I changed the listener code to only modify trim in the window containing the perspective whose id changed rather than all windows...when we do a 'save as' the only window affected should be the one we're in.

Comment 5 Eric Moffatt

2011-09-23 11:40:00 EDT

Rather than applying the warnings patch I've opened a separate defect (bug 358739) to track a solution that will fix our dependency on workbench rather than getting 'friendly'...

Nice work, thanks!

Comment 6 Eric Moffatt

2011-10-26 13:44:08 EDT

Verified in I20111025-2000.