Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357853 - Cannot use multiple workbench windows with saved perspectives
Summary: Cannot use multiple workbench windows with saved perspectives
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Eric Moffatt CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 14:18 EDT by Remy Suen CLA
Modified: 2011-10-26 10:44 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-09-15 14:18:00 EDT 
I20110914-0200

1. Window > Save Perspective As... > Give it a name > OK
2. Window > New Window
3. The new window steals the shared area from the first window. Trying to active the first window will activate the second window.
Comment 1 Eric Moffatt CLA 2011-09-29 14:44:20 EDT 
This is because the current code is cloning the value of the MPlaceholder's 'ref' (so it's pointing at the one in the original window.

I'm currently working on this; I have code in ElementReferenceRenderer that will reset the ref (based on id), creating and adding the MPart/MArea to the new window's sharedParts list if necessary.

There are still some issues to be worked out though...
Comment 2 Eric Moffatt CLA 2011-10-05 12:40:57 EDT 
Pushed in >201101005.

commit b9cca45a2414af0c391374cb7879ed4bc1e12834

There is still some issue that cause the main menu to change in the non-active window but this appears to be unrelated to this work.
Comment 3 Eric Moffatt CLA 2011-10-05 12:45:25 EDT 
Dean, I didn't seem to be able to get the MPlaceholder's 'ref' feature to be null in the clone even though I had changed its 'derived' state to 'true' in the model. 

For now I have code that explicitly 'nulls' them but it seems like the 'derived' thing should have worked...feel free to check this, I'd gladly remove the null'ing code if we can make it automagic...
Comment 4 Eric Moffatt CLA 2011-10-05 13:17:07 EDT 
Pushed in >20111005. Commit to fix many of the warnings in the ModelService.

commit e1e80dd71f90a93b51ba36c17252909521dde74e
Comment 5 Paul Webster CLA 2011-10-05 15:19:29 EDT 
(In reply to comment #2)
> There is still some issue that cause the main menu to change in the non-active
> window but this appears to be unrelated to this work.

Did you open a bug and capture the repo steps?  We should probably track that down :-)

PW
Comment 6 Remy Suen CLA 2011-10-05 16:06:20 EDT 
(In reply to comment #5)
> Did you open a bug and capture the repo steps?

Eric showed me this on his computer. It's bug 348920.
Comment 7 Eric Moffatt CLA 2011-10-26 10:44:08 EDT 
Verified in I20111025-2000.