Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357845 - DataModelFacetCreationWizardPage creates listeners that are not cleaned up in the dispose method
Summary: DataModelFacetCreationWizardPage creates listeners that are not cleaned up in...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: wst.web (show other bugs)
Version: 3.2.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.2   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on: 357560
Blocks:
  Show dependency tree
 
Reported: 2011-09-15 13:29 EDT by Roberto Sanchez Herrera CLA
Modified: 2011-10-12 16:46 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
Proposed patch for WTP 3.3.2 (using R3_3_maintenance) (3.80 KB, patch)
2011-10-10 16:13 EDT, Roberto Sanchez Herrera CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-09-15 13:29:27 EDT 
+++ This bug was initially created as a clone of Bug #357560 +++

The class org.eclipse.wst.web.ui.internal.wizards.DataModelFacetCreationWizardPage creates listeners (IFacetedProjectListener) that are not
cleaned up in the dispose method. This can cause problem in case other classes
are using the data model (containing the faceted project this listeners are listening to) after the page is disposed. In fact, the page
should not act on the model if it has been already disposed.
Comment 1 Roberto Sanchez Herrera CLA 2011-09-15 13:37:20 EDT 
This bug is to commit code to WTP 3.3.2
Comment 2 Roberto Sanchez Herrera CLA 2011-10-10 16:13:07 EDT 
Created attachment 204907 [details]
Proposed patch for WTP 3.3.2 (using R3_3_maintenance)
Comment 3 Chuck Bridgham CLA 2011-10-12 14:42:43 EDT 
approved
Comment 4 Roberto Sanchez Herrera CLA 2011-10-12 16:46:11 EDT 
Code committed to R3_3_maintenance for WTP 3.3.2. Resolving bug.