Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357814 - Allow a snap bundle to have multiple hosts
Summary: Allow a snap bundle to have multiple hosts
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: snaps (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.7.0.M04   Edit
Assignee: daniel marthaler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 10:18 EDT by Simon Watson CLA
Modified: 2016-12-14 09:18 EST (History)
4 users (show)

See Also:


Attachments
Path that implements support for multiple snap-hosts (38.88 KB, patch)
2016-11-18 16:28 EST, Stefan Zugal CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Watson CLA 2011-09-15 10:18:18 EDT
Build Identifier: 

As per this discussion thread (http://www.eclipse.org/forums/index.php/t/240197/), I would like to use a snap bundle to encapsulate web theme resources for a number of web app bundles. 

I have 3 WABs (using common data/business bundles) which are all branded identically for different customers. So, at present, I have an identical set of files (css, images) in these 3 bundles. I would like to create a snap bundle which contains these resources, and which can be 'attached' to multiple WAB bundles.

As I understand it, at present, a snap bundle can only have one host. I think it would be a useful enhancement to allow a snap bundle to specify multiple hosts in its manifest header. 


Reproducible: Always
Comment 1 Stefan Zugal CLA 2016-11-08 15:09:40 EST
We are using quite a similar setup and have already adapted the snaps to allow for multiple hosts. I will try to extract the changes we made as patch and provide it here as soon as possible (hopefully next week).
Comment 2 Stefan Zugal CLA 2016-11-18 16:28:24 EST
Created attachment 265451 [details]
Path that implements support for multiple snap-hosts

Attached please find the changes we made for making snaps attachable to multiple hosts.
Comment 3 daniel marthaler CLA 2016-11-24 04:52:01 EST
Hi Stefan

Thank you very much for contributing the patch. I hopefully find some time next week to over it and merge it into development branch.

Regards,
Dani
Comment 4 Stefan Zugal CLA 2016-11-24 07:54:48 EST
That is great to hear - I will wait for your feedback then.
Comment 5 daniel marthaler CLA 2016-11-26 11:19:11 EST
Hi Stefan, 
I reviewed your contribution and applied the patch to development. Build job on Hudson is running, pls download the result [1] and check if everything works as expected. Post the outcome here so I can close this Bug if everything is fine.

[1] https://hudson.eclipse.org/virgo/view/Snaps/job/Snaps-Development/2/artifact/build/distributions/snaps-3.7.0.M04.zip
Comment 6 Stefan Zugal CLA 2016-11-28 10:11:43 EST
Wow, that was fast - thanks! I hope I will have time this week to test the outcome.
Comment 7 Stefan Zugal CLA 2016-12-04 09:55:04 EST
I just checked the build you posted - everything works as expected, thanks!
Comment 8 daniel marthaler CLA 2016-12-12 01:42:01 EST
Hi Stefan,

thank you for checking the build. Do you have time to update the documentation for Snaps as well?

Regards,
Dani
Comment 9 Stefan Zugal CLA 2016-12-13 08:17:35 EST
Hi Dani,

yes, sure. Do you have any tips on how to edit the documentation (I assume you are referring to the directory "snaps-guide")? I have seen that the documentation is compiled from a set of xml files... do you just edit the source - or do you have any particular editor at hand?

Cheers,
Stefan
Comment 10 daniel marthaler CLA 2016-12-14 09:18:20 EST
(In reply to Stefan Zugal from comment #9)
> yes, sure. 
Thank you very much.

>Do you have any tips on how to edit the documentation 
Well, not really. But I will check which Eclipse Plugin we could use and then make sure the Gradle build prepares everything.

>(I assume you are referring to the directory "snaps-guide")? 
Yes, exactly. I will now close this Bug and open two additional ones. The First one [1] for integrating the snaps-guide subproject in the Snaps Gradle build and a second one [2] for you to do the actual documentation task for the newly introduced features.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=509225
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=509226

Regards,
Dani