Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357800 - Make "Base Package" just a setting of "web client with services" template
Summary: Make "Base Package" just a setting of "web client with services" template
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Xiao Bin Chen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 09:42 EDT by Will Smythe CLA
Modified: 2017-02-23 14:15 EST (History)
3 users (show)

See Also:


Attachments
Fix (17.50 KB, patch)
2011-10-10 04:20 EDT, Huang Ji Yong CLA
lasher: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Will Smythe CLA 2011-09-15 09:42:59 EDT
The "base package" concept should be moved from being a project-level setting (that applies - or could apply - to each template) to a setting of the "web client with services" template, since this is really the only template that *needs* it. The "base package" field should appear above the widget libraries table presented on the 3rd page of the wizard (when the 'web client with services' template is selected).

See my note from 9/2 for more detail.
Comment 1 Will Smythe CLA 2011-09-15 09:43:23 EDT
I think we need to have this correct for 0.7 ..
Comment 2 Will Smythe CLA 2011-09-15 09:43:52 EDT
This issue came out of the IDE scrubbing work that Theresa and I recently started.
Comment 3 Huang Ji Yong CLA 2011-10-10 04:20:19 EDT
Created attachment 204858 [details]
Fix
Comment 4 Huang Ji Yong CLA 2011-10-10 04:21:29 EDT
Move base package to  "web client with services" template
Comment 5 Brian Svihovec CLA 2011-10-11 11:02:51 EDT
I downloaded the build from 201110100900 and we do not appear to be creating a 'client' package when a user chooses to create a 'Web client' only project.  I believe we should still be creating a 'client' package for this type of project.
Comment 6 Huang Ji Yong CLA 2011-10-11 23:04:11 EDT
The problem seems not caused by this work item. Moreover, Brenda has opened this issue as a defect in bug 360598. So close this work item.
Comment 7 Will Smythe CLA 2011-11-02 00:26:29 EDT
I think we need to look again at this.

For the 'Web 2.0 client application' template, we either need to not create any packages (because packages are not technically required since everything is JavaScript targeted) OR need to ask the user for a base package if we are going to create a 'client' and a 'common' package. Currently the user is not able to specify a base package, but yet the wizard still creates a 'client' and a 'common' package. This doesn't make sense to me ...
Comment 8 Tony Chen CLA 2011-11-08 01:59:31 EST
I summarized the behavior of base package below. Please confirm if this is what you are thingking. 

Basic project
   no base package input
   no package created

Client project
   provide base package input
   create client & common package if base package input is not empty, no need to configure generator, all inherit JSGenerator from project. 

Client with Service project
   provide base package input
   create client, common & server package if base package input is not empty, configure generator accordingly.
Comment 9 Will Smythe CLA 2011-11-10 21:03:10 EST
Tony - here is a slight update to what you proposed:

Basic project
   no base package input
   no package created

Client project
   provide base package input
   create client package (using whatever base package was specified), no need to configure generator, all inherit JSGenerator from project. 

Client with Service project
   provide base package input
   create client, common & server packages (using whatever base package was specified), configure generator accordingly.

====

Some examples ...

Example 1:

 Template: Web 2.0 client
 Base package: "" (empty string)
 Packages created:
    client

Example 2:

 Template: Web 2.0 client
 Base package: com.mycompany
 Packages created:
   com.mycompany.client

Example 3:

 Template: Web 2.0 client with services
 Base package: "" (empty string)
 Packages created:
    client
    common
    server

Example 4:

 Template: Web 2.0 client with services
 Base package: com.mycompany
 Packages created:
   com.mycompany.client
   com.mycompany.common
   com.mycompany.server
Comment 10 Tony Chen CLA 2011-11-10 21:28:14 EST
Set to Major because they are things newer developers may run into fairly quickly
Comment 11 Xiao Bin Chen CLA 2011-11-11 07:46:20 EST
It was fixed .
Comment 12 Will Smythe CLA 2011-11-17 21:10:47 EST
Looks good.