Community
Participate
Working Groups
Build Identifier: 3.6.2.M20110210-1200 Hello, the delete key (SWT.DEL) is not working properly for CCombo. Following points have been observed: - The binding to the delete key seems to eat the keystroke (in WorkbenchKeyboard) - Although the CCombo internally uses a Text widget, the exception in WorkbenchKeyboard.filterKeySequenceBindings() for the Text widget is not working since the CCombo wraps the event into a new event which has the CCombo set as the events widget. Seems like either CCombo has to handle this special case differently or WorkbenchKeyboard includes CCombo (like Text, Combo and Browser) as an exception to the out of order processing. Looks like this is no issue if there is nothing bound to the delete command, but I would expect this to work even with something bound to the command (like the Text widget). Eclipse: 3.6.2.M20110210-1200 SWT: 3.6.2.v3659c Reproducible: Always Steps to Reproduce: 1. Create an FormEditor 2. Add an editable CCombo 3. Add a handler to the command org.eclipse.ui.edit.delete 4. Try using delete in the CCombo
Created attachment 222288 [details] Patch that adds CCombo as an exception in WorkbenchKeyboard#filterKeySequenceBindings I have fixed this by adding CCombo to exception list as proposed in the description. Note: I have removed the project name from the patch to make it easier to apply it on a plug-in imported as Source Project (without using EGit).
Silenio, what do you think about making the exception for a CCombo box (in our UI Display filter)? PW
It seems ok to me, since CCombo is a Text widget and we already have the exception for Text.
Will this get backported to 4.2.2/3.8.2?
(In reply to comment #4) > Will this get backported to 4.2.2/3.8.2? It won't get backported to 3.8.2. I'm less sure about 4.2.2, but right now the plan is no. PW
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=7f20fdb1be1922ca600237b18c6ab39484fd2552 Thanx Joachim PW
In M20130116-1800 PW
