Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357738 - Opening Gerrit short URLs in Review editor does not work
Summary: Opening Gerrit short URLs in Review editor does not work
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 0.9   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 359632 (view as bug list)
Depends on:
Blocks: 346046
  Show dependency tree
 
Reported: 2011-09-15 04:48 EDT by Sascha Scholz CLA
Modified: 2012-02-01 20:43 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Scholz CLA 2011-09-15 04:48:16 EDT 
The gerrit connector doesn't recognize http://egit.eclipse.org/r/3297 as URL that is opened in the review editor. Only http://egit.eclipse.org/r/#change,3297 works.
Comment 1 Steffen Pingel CLA 2011-09-15 05:14:50 EDT 
It looks like the web interface does a search when you click on the shortened URL. We can try to support this but we can't do any lookups when analyzing the URL since processing happens on the UI thread.
Comment 2 Sascha Scholz CLA 2011-09-15 07:40:57 EDT 
The short URL is also used by Gerrit in review notes. Would be nice to be able to navigate from commit viewer note to review editor
Comment 3 Steffen Pingel CLA 2011-10-04 06:49:13 EDT 
*** Bug 359632 has been marked as a duplicate of this bug. ***
Comment 4 Steffen Pingel CLA 2012-01-31 16:43:59 EST 
This is now supported in master.
Comment 5 Steffen Pingel CLA 2012-02-01 17:00:18 EST 
Need to investigate hanging tests due to a browser popup:

Thread[main,6,main]
  org.eclipse.swt.internal.gtk.OS.Call(Native Method)
  org.eclipse.swt.widgets.Display.sleep(Display.java:4069)
  org.eclipse.swt.browser.PromptDialog.promptUsernameAndPassword(PromptDialog.java:429)
  org.eclipse.swt.browser.PromptService2.PromptAuth(PromptService2.java:505)
  org.eclipse.swt.browser.PromptService2$3.method12(PromptService2.java:80)
  org.eclipse.swt.internal.mozilla.XPCOMObject.callback12(XPCOMObject.java:95)
  org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
  org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2276)
  org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3207)
  org.eclipse.mylyn.gerrit.tests.ui.GerritUrlHandlerTest.testOpenUrl(GerritUrlHandlerTest.java:56)
Comment 6 Steffen Pingel CLA 2012-02-01 20:43:28 EST 
Tests are now passing.