Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357682 - [ActivityDiagram] control flow should automatically create guard and weight
Summary: [ActivityDiagram] control flow should automatically create guard and weight
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Pauline Deville CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 16:22 EDT by Raphael Faudou CLA
Modified: 2017-09-01 04:20 EDT (History)
4 users (show)

See Also:

Attachments
Add true as Default Value to the Guard and 0 as Default value to The Weith of a control flow (1.36 MB, application/octet-stream)
2011-09-30 09:57 EDT, RADOUANI anass CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Faudou CLA 2011-09-14 16:22:14 EDT 
When creating a control flow between two actions, weight and guard properties are not set. As they are mandatory, the model is not valid.
Guard should be created with default value = true
Weight should be created with default value = 0
By default, those two labels should not be visible.
Comment 1 RADOUANI anass CLA 2011-09-30 09:57:45 EDT 
Created attachment 204382 [details]
Add true as Default Value to the Guard and 0 as Default value to The Weith of a control flow

I, Anass Radouani, have written 100% of the code contributed to fix this bug.
I have the right to contribute this code and have filled the headers with the
appropriate License.
This contribution has been checked by and committed under the responsability of
Tristan FAURE.
Comment 2 Mathieu Velten CLA 2011-09-30 11:58:11 EDT 
commited on branch & trunk
Comment 3 Raphael Faudou CLA 2011-10-02 07:48:42 EDT 
Works but visibility has not been managed.
By default we do not want to see :
* weight which is very rarely used.
* control flow name as it does not provide any semantics (semantics are given by the arrow itself as a sequence between two actions)
* guard. It is usefull to see but generally most control flow will not have guard. So guard will be made visible by end user with label connector management.

note: recent work might have introduced a regression on validation.
Comment 4 Eclipse Genie CLA 2017-03-09 08:35:29 EST 
New Gerrit change created: https://git.eclipse.org/r/92691
Comment 5 Eclipse Genie CLA 2017-08-30 10:19:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/104002
Comment 7 Eclipse Genie CLA 2017-09-01 04:19:50 EDT 
Gerrit change https://git.eclipse.org/r/104002 was merged to [streams/3.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=f161c1dcd4c3ded442b28f65ca4358b90c9cff2d