Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357654 - StackOverFlowError selecting Add Required Plugins at Target Platform preference, Target Definition dialog, Content tab
Summary: StackOverFlowError selecting Add Required Plugins at Target Platform preferen...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 12:08 EDT by Eddie Galvez CLA
Modified: 2011-09-30 18:23 EDT (History)
1 user (show)

See Also:

Attachments
Possible fix (531.08 KB, patch)
2011-09-15 12:57 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eddie Galvez CLA 2011-09-14 12:08:04 EDT 
StackOverFlowError after clicking "Add Required" in the Target Platform pref, Edit Target Definition, Content tab, after selecting com.soyatec.edepend (installed at target platform from within it using http://www.soyatec.com/update/helios)


-- Error Details --
Date: Wed Sep 14 12:04:19 EDT 2011
Message: Unhandled event loop exception
Severity: Error
Product: Eclipse 1.4.0.20110609-1120 (org.eclipse.epp.package.rcp.product)
Plugin: org.eclipse.ui
Session Data:
eclipse.buildId=I20110613-1736
java.version=1.6.0_26
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.rcp.product
Command-line arguments:  -data C:\Users\eddie\Documents\Workspaces\37_ruggles -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.rcp.product

Exception Stack Trace:
java.lang.StackOverflowError
	at org.eclipse.pde.internal.core.feature.Feature.getImports(Feature.java:106)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:831)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:837)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:837)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:837)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:837)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.getFeatureDependencies(TargetContentsGroup.java:837)
<and repeat, that's all I can see>
Comment 1 Curtis Windatt CLA 2011-09-15 12:02:22 EDT 
Can you provide detailed steps with a new target definition? I tried using the provided update site, but don't get any features to get dependencies for (just plug-ins).  Please include any changes you made to the options on the wizard.

I can take guesses what the root cause is, but it sounds like it shouldn't be hard to set up a reproducible test case.
Comment 2 Curtis Windatt CLA 2011-09-15 12:57:23 EDT 
Created attachment 203424 [details]
Possible fix

If the problem is circular dependencies in your features, this patch should correct it, along with some minor improvements.
Comment 3 Curtis Windatt CLA 2011-09-30 18:23:44 EDT 
This has been fixed in master

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=65627e21627860173b5bc005c81a79998fbded86