Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357627 - ExceptionHandlerManager trusted ExceptionHandler that they dont fail
Summary: ExceptionHandlerManager trusted ExceptionHandler that they dont fail
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: Look And Feel (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 09:31 EDT by Christian Campo CLA
Modified: 2011-09-14 09:33 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Campo CLA 2011-09-14 09:31:49 EDT 
Currently the ExceptionHandlerManager trusts that the "handle" method of the ExceptionHandler does not fail. If it fails, no other ExceptionHandler is called and also the caller of ExceptionHandlerManager will fail with an exception.

So in this case the UIProcess in its run method, called the EHM to deal with a NPE that a UIProcess threw. The ExceptionHandler wanted to open a MessageBox without taking into account, that this only works on UI-Threads. The ExceptionHandler failed and so did everything else. The monitor of UIProcess was never finished and unfinished UIProcess instances started pilling up.

The solution is to not trust the handler, catch the exception, log it as error and proceed as if the handler did not processed the exception.
Comment 1 Christian Campo CLA 2011-09-14 09:33:01 EDT 
fixed in HEAD