Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357626 - Overwritten prototypes
Summary: Overwritten prototypes
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.3   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 357890 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-09-14 09:13 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-16 12:12 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-09-14 09:13:46 EDT 
In some places we are creating a new class propotyle by overriding other class prototype, like this:
MyClass.propotype = MyOtherClass.prototype;
This is bad, because modifying MyClass.prototype we are also modifying MyOtherClass.prototype, we should use this:
MyClass.prototype = new MyOtherClass();
This is in several places especially explorer.
Comment 1 Malgorzata Janczarska CLA 2011-09-16 08:33:00 EDT 
I went though our code and corrected places I could find, mostly situated in navigators. Hopefully I corrected it all.
Comment 2 Simon Kaegi CLA 2011-09-16 12:12:20 EDT 
*** Bug 357890 has been marked as a duplicate of this bug. ***