Community
Participate
Working Groups
In the dialog to load a customization, I think you should precise the metamodel for each customization. I think there is 2 ways to do that : - add a tag [UML/Ecore/...] before the name of the customization + sort by alphabetical order or - use a TreeViewer for the group the customization by Metamodel : - UML - customization1 - customization2 - Ecore - customization1,... I do the same comment for the Load Facet Dialog
Good idea but may be not for this year. => P5
Created attachment 212532 [details] This patch adds tabs in the ETypedElementSelectionDialog. (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 212533 [details] icons for the previous patch (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Comment on attachment 212532 [details] This patch adds tabs in the ETypedElementSelectionDialog. Partick, please, can you commit this patch. Regards, Grégoire
These icons are already used by the package explorer, in the view menu -> Package Presentation. You can find them in the plugins org.eclipse.search too for example. I rename them for my new feature : flatLayout -> flatView and hierarchicalLayout -> treeView.
Comment on attachment 212533 [details] icons for the previous patch Patrick, according to the comment #5, you can commit this contribution.
Comment on attachment 212532 [details] This patch adds tabs in the ETypedElementSelectionDialog. Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html) I've committed this contribution. Committed revision 1812.
Comment on attachment 212533 [details] icons for the previous patch Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html) I've committed this contribution. Committed revision 1812.
This bug can marked as fixed. Vincent, please, can you check that your contribution has been properly integrated and close this bug ?
The contribution has not been properly integrated. The new field knownEPackage is not used in the sortedController.
Created attachment 213839 [details] Correct this bug in order to use knownEPackage (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 214111 [details] Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 214686 [details] Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage + correct the method getChildren (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Comment on attachment 214686 [details] Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage + correct the method getChildren This patch modifies less than 250 lines (93 lines). I've committed this patch. Committed revision 2141.
Created attachment 214693 [details] Rename the tabs and their tooltips (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 214696 [details] Remove PMD and checkstyle warning in ETypedElementSelectionSortedControl (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Comment on attachment 214693 [details] Rename the tabs and their tooltips Here is a patch smaller than 250 lines (11 lines added or modified). I've committed this patch. Committed revision 2164.
Comment on attachment 214696 [details] Remove PMD and checkstyle warning in ETypedElementSelectionSortedControl Here is a patch smaller than 250 lines (-11 / +14 lines). I've committed this patch (+ some more cleaning by my self). Committed revision 2166.
This bug can be marked as closed.
