Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357587 - Custom sorter is changed to SystemTableViewSorter
Summary: Custom sorter is changed to SystemTableViewSorter
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 357961
  Show dependency tree
 
Reported: 2011-09-14 01:43 EDT by Missing name CLA
Modified: 2011-09-30 14:58 EDT (History)
1 user (show)

See Also:

Attachments
patch to update column number for existing sorter (3.57 KB, patch)
2011-09-14 13:21 EDT, David McKnight CLA 		no flags Details | Diff
updated patch to include regular table view as well (5.51 KB, patch)
2011-09-14 13:40 EDT, David McKnight CLA 		no flags Details | Diff
updated patch (5.63 KB, patch)
2011-09-16 12:50 EDT, David McKnight CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2011-09-14 01:43:28 EDT 
I created a custom sorter that is extended from SystemTableViewSorter.
When I click the header of table view, sorter is changed to SystemTableViewSorter.

The widgetSelected() of HeaderSelectionListener, the inner class of SystemTableTreeView, should use old sorter even if column is not same as older column.
Comment 1 David McKnight CLA 2011-09-14 13:12:45 EDT 
Could you explain how you're adding your custom sorter to the SystemTableTreeView?
Comment 2 David McKnight CLA 2011-09-14 13:21:07 EDT 
Created attachment 203347 [details]
patch to update column number for existing sorter

Could you try with this patch?  I had to add a new method to SystemTableViewSorter however that class is internal.
Comment 3 David McKnight CLA 2011-09-14 13:40:10 EDT 
Created attachment 203350 [details]
updated patch to include regular table view as well
Comment 4 Missing name CLA 2011-09-15 10:50:59 EDT 
I tried new patch. It is OK.
Comment 5 David McKnight CLA 2011-09-15 11:07:47 EDT 
(In reply to comment #4)
> I tried new patch. It is OK.

Do you require a backport to the R3_2_maintenance stream?
Comment 6 Missing name CLA 2011-09-16 03:25:29 EDT 
Please make a backport to the R3_2_maintenance stream.
Comment 7 David McKnight CLA 2011-09-16 12:50:31 EDT 
Created attachment 203499 [details]
updated patch
Comment 8 David McKnight CLA 2011-09-27 09:55:47 EDT 
Kevin, could you please review this patch?
Comment 9 David McKnight CLA 2011-09-30 11:30:02 EDT 
I've committed the fix to the HEAD stream.
Comment 10 Martin Oberhuber CLA 2011-09-30 14:58:11 EDT 
Updated the rse.ui bundle version and released into the mapfile for 3.4m3.