Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357560 - DataModelFacetCreationWizardPage creates listeners that are not cleaned up in the dispose method
Summary: DataModelFacetCreationWizardPage creates listeners that are not cleaned up in...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: wst.web (show other bugs)
Version: 3.2.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 357845
  Show dependency tree
 
Reported: 2011-09-13 16:48 EDT by Roberto Sanchez Herrera CLA
Modified: 2011-09-15 13:31 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
Proposed patch (3.80 KB, patch)
2011-09-13 17:14 EDT, Roberto Sanchez Herrera CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-09-13 16:48:12 EDT 
The class org.eclipse.wst.web.ui.internal.wizards.DataModelFacetCreationWizardPage creates listeners (IFacetedProjectListener) that are not
cleaned up in the dispose method. This can cause problem in case other classes
are using the data model (containing the faceted project this listeners are listening to) after the page is disposed. In fact, the page
should not act on the model if it has been already disposed.
Comment 1 Roberto Sanchez Herrera CLA 2011-09-13 17:14:17 EDT 
Created attachment 203305 [details]
Proposed patch

Patch to remove the listeners on dispose. The model is set to null as well,
given that this class should not act on the model after being disposed
Comment 2 Chuck Bridgham CLA 2011-09-14 10:38:35 EDT 
approved
Comment 3 Roberto Sanchez Herrera CLA 2011-09-14 12:02:49 EDT 
Code committed to R3_2_maintenance and HEAD for WTP 3.2.5 and 3.4. I'll keep this defect open to commit this code to WTP 3.3.2.
Comment 4 Roberto Sanchez Herrera CLA 2011-09-15 13:31:08 EDT 
Created bug 357845 for WTP 3.3.2. Resolving defect
Comment 5 Roberto Sanchez Herrera CLA 2011-09-15 13:31:15 EDT 
Created bug 357845 for WTP 3.3.2. Resolving defect