Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357549 - Palette creation: name and description from ICreationToolEntry are ignored
Summary: Palette creation: name and description from ICreationToolEntry are ignored
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Tim Kaiser CLA
QA Contact:
URL:
Whiteboard: Juno M2 Theme_round_offs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 15:40 EDT by Hernan Gonzalez CLA
Modified: 2012-06-28 10:43 EDT (History)
1 user (show)

See Also:
michael.wenz: iplog+
tim.kaiser: juno+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hernan Gonzalez CLA 2011-09-13 15:40:59 EDT
Build Identifier: 

A Graphiti ICreationToolEntry has a name and description, which are usually (but no necesarily) taken from the CreateFeature. However, when the GEF PaletteEntry is created (GFPaletteRoot.createTool() method) the name and description are not read from the ICreationToolEntry but from the CreationFeature. 
This is wrong, it turns the ICreationToolEntry name/description useless, and does not allow to create several palette entries which call distinct instantiations of a same CreateFeature

CombinedTemplateCreationEntry pe = new CombinedTemplateCreationEntry(feat.getCreateName(), feat.getCreateDescription(),
template, cf, getImageDescriptor(creationToolEntry, true), getImageDescriptor(creationToolEntry, false));

should be

CombinedTemplateCreationEntry pe = new CombinedTemplateCreationEntry(creationToolEntry.getLabel(), creationToolEntry.getDescription(), template, cf, getImageDescriptor(creationToolEntry, true), getImageDescriptor(creationToolEntry, false));
				


Reproducible: Always
Comment 1 Tim Kaiser CLA 2011-09-21 10:01:58 EDT
correct. i also removed i a useless instanceof check...
Comment 2 Michael Wenz CLA 2012-04-11 10:37:41 EDT
Bookkeeping: Set target release
Comment 3 Michael Wenz CLA 2012-05-09 08:20:32 EDT
Relevant for IP log
Comment 4 Michael Wenz CLA 2012-06-28 10:43:24 EDT
Part of Graphiti 0.9.0 (Eclipse Juno)