Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357512 - Factorize common attributes of To and From element into an AbstractAssignBound element
Summary: Factorize common attributes of To and From element into an AbstractAssignBoun...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Robert Brodt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 11:25 EDT by Mickael Istria CLA
Modified: 2022-10-03 11:11 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (107.57 KB, patch)
2011-12-05 06:56 EST, Mickael Istria CLA 		bbrodt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2011-09-13 11:25:56 EDT 
Currently, a big part of To and From is duplicated, making the code redundant and then harder to maintain when dealing with these elements.
Factorizing their shared attributes in a common item would be very convenient,
Comment 1 Mickael Istria CLA 2011-09-13 12:24:52 EDT 
You can have a look at this change set, https://github.com/mickaelistria/org.eclipse.bpel/commit/41006bfab8bc0fb9e7b67cfda51616b7b2e7f1bd
It is working fine with manual tests (serialization and parsing OK).
Comment 2 Robert Brodt CLA 2011-09-13 16:01:32 EDT 
Thanks Mickael, I'll take a look this week. Also your suggestions about github has been noted - thank you :)
Comment 3 Mickael Istria CLA 2011-11-03 09:30:32 EDT 
Bob, did you have time to take a look at this proposition?
Having this factorization makes work *much* easier when dealing with the mapping stuff I've worked on.
Comment 4 Mickael Istria CLA 2011-12-05 06:56:43 EST 
Created attachment 207910 [details]
Proposed patch

This patch factorize the To and From common attributes into an AbstractAssignBound element.
This only introduce a new abstract type, and does not affect the current code.
I helps is saving lots of type casting when dealing with assign elements.
Comment 5 Robert Brodt CLA 2011-12-05 08:55:22 EST 
Sorry Mickail, I've been swamped with work and haven't had the time to work on BPEL lately.

Vincent or Tobias, can you look at this patch, verify and merge into master branch?

Thanks all!
Comment 6 Vincent Zurczak CLA 2012-01-05 11:53:30 EST 
The patch was applied.