Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357501 - [terminal][api] In case of an error on a terminal settings page, no indication is given what's wrong
Summary: [terminal][api] In case of an error on a terminal settings page, no indicatio...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 7
: P4 minor (vote)
Target Milestone: 4.0   Edit
Assignee: dsdp.tm.core-inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2011-09-13 10:23 EDT by Martin Oberhuber CLA
Modified: 2015-05-07 02:26 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2011-09-13 10:23:11 EDT 
CQ:WIND00253872
Build ID: TM 3.3

Steps to Reproduce:
1. Open the terminal view (Window > Show View > Terminal).
2. Press the "Connection Properties" buttons and pick Telnet connection.
3. Enter a host name, and 77777 as the port number. Press OK.
4. The dialog says the settings are wrong without mentioning what is wrong.

The problem as per a TODO comment in the header of ISettingsPage.java -- the ISettingsPage doesn't provide API for settings implementations to give an error string when validation fails. 

It may be possible for each SettingsPage to use an error indicator on a Field that has a wrong value... but that would require each settingsPage to code the respective UI work, rather than just returning a common error text similar to existing Eclipse Wizard framework.
Comment 1 Uwe Stieber CLA 2015-05-07 02:26:35 EDT 
Fixed with TM Terminal 4.0