Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357495 - Error in plugin.js when /workspace return 401
Summary: Error in plugin.js when /workspace return 401
Status: CLOSED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.3   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 355396
  Show dependency tree
 
Reported: 2011-09-13 10:02 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-15 04:14 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-09-13 10:02:52 EDT
When call to /workspace returns 401 the error is not returned, but instead an error from plugin.js (line 37) is returned, therefore login prompt is not displayed.
Simon, you've been changing something in those lines recently? Maybe it has something to do with it?

To reproduce open navigator while not authenticated.

stack trace:
[Exception... "The object could not be cloned." code: "25" nsresult: "0x80530019 (NS_ERROR_DOM_DATA_CLONE_ERR)" location: "http://localhost:8080/orion/plugin.js Line: 37"]
(?)(x=[Exception... "The object could not be cloned." code: "25" nsresult: "0x80530019 (NS_ERROR_DOM_DATA_CLONE_ERR)" location: "http://localhost:8080/orion/plugin.js Line: 37"] { constructor=DOMException, lineNumber=37, code=25, more...})dojo.j...ssed.js (line 4142)
errback(error=[Exception... "The object could not be cloned." code: "25" nsresult: "0x80530019 (NS_ERROR_DOM_DATA_CLONE_ERR)" location: "http://localhost:8080/orion/plugin.js Line: 37"] { constructor=DOMException, lineNumber=37, code=25, more...})dojo.j...ssed.js (line 4142)
notify()dojo.j...ssed.js (line 4112)
complete(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4087)
callback(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4129)
notify()dojo.j...ssed.js (line 4109)
complete(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4087)
errback(error=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4139)
notify()dojo.j...ssed.js (line 4116)
complete(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4087)
callback(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4129)
notify()dojo.j...ssed.js (line 4109)
complete(value=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4087)
errback(error=
Error: Unable to load /workspace status:401
[Break On This Error] var err = new Error("Unable to load...Args.url + " status:" + xhr.status);
dojo.j...ssed.js (line 10588)
)dojo.j...ssed.js (line 4139)
_resHandle(dfd=Object { promise={...}, ioArgs={...}, startTime=1315921668097, more...})dojo.j...ssed.js (line 10591)
func()dojo.j...ssed.js (line 10471)
_watchInFlight()dojo.j...ssed.js (line 10490)
(dojo.config.deferredOnError || function(x){ console.error(x); })(error);
dojo.j...ssed.js (line 4142)
Comment 1 Simon Kaegi CLA 2011-09-13 10:55:25 EDT
Sorry Gosia, this is a further symptom of the change I did to add binary support.

*** This bug has been marked as a duplicate of bug 357487 ***
Comment 2 Simon Kaegi CLA 2011-09-14 09:21:59 EDT
Re-opening -- the problem here is that we're trying to send an error object over postMessage. We need to sanitize it first to allow it to be sent safely.
Comment 3 Malgorzata Janczarska CLA 2011-09-15 04:14:00 EDT
The problem is fixed now. Thanks Simon!