357473 – Improve test coverage for DeployerArtifact, DefaultArtifactObjectNameCreator and DeployerBundleArtifact

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357473 - Improve test coverage for DeployerArtifact, DefaultArtifactObjectNameCreator and DeployerBundleArtifact

Summary: Improve test coverage for DeployerArtifact, DefaultArtifactObjectNameCreator ...

Status:	CLOSED FIXED

Alias:	None

Product:	Virgo
Classification:	RT
Component:	runtime (show other bugs)
Version:	unspecified
Hardware:	PC Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	3.5.0.RELEASE
Assignee:	Glyn Normington
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	325617
	Show dependency tree

Reported:	2011-09-13 07:50 EDT by Florian Waibel
Modified:	2011-09-14 09:56 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Added kernel.core to kernel.model AspectJ inpath to enable @NotNull checks. (1.73 KB, patch) 2011-09-13 07:50 EDT, Florian Waibel	glyn.normington: iplog+	Details \| Diff
Added tests for DeployerBundleArtifact. (6.64 KB, patch) 2011-09-13 07:51 EDT, Florian Waibel	glyn.normington: iplog+	Details \| Diff
Added tests for DeployerArtifact. (5.96 KB, patch) 2011-09-13 07:52 EDT, Florian Waibel	glyn.normington: iplog+	Details \| Diff
Added tests for DefaultArtifactObjectNameCreator. (2.39 KB, patch) 2011-09-13 07:52 EDT, Florian Waibel	glyn.normington: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Waibel

2011-09-13 07:50:10 EDT

I added some JUnit tests for:
 * DefaultArtifactObjectNameCreator
 * DeployerArtifact
 * DeployerBundleArtifact

Comment 1 Florian Waibel

2011-09-13 07:50:51 EDT

Created attachment 203237 [details]
Added kernel.core to kernel.model AspectJ inpath to enable @NotNull checks.

Comment 2 Florian Waibel

2011-09-13 07:51:42 EDT

Created attachment 203238 [details]
Added tests for DeployerBundleArtifact.

Comment 3 Florian Waibel

2011-09-13 07:52:07 EDT

Created attachment 203239 [details]
Added tests for DeployerArtifact.

Comment 4 Florian Waibel

2011-09-13 07:52:35 EDT

Created attachment 203240 [details]
Added tests for DefaultArtifactObjectNameCreator.

Comment 5 Glyn Normington

2011-09-13 17:33:53 EDT

Hi Florian

Thanks for the contribution! Great to see more kernel tests.

Please confirm that you wrote 100% of the code and you have the rights to contribute it.

Regards,
Glyn

Comment 6 Florian Waibel

2011-09-14 03:43:17 EDT

You are welcome.
Sorry for the inconvenience caused due to missing confirmation and iplog flag.

I confirm that I have written 100% of the attached patch and that
I'm allowed to contribute the patch to eclipse.org.

Comment 7 Glyn Normington

2011-09-14 09:56:22 EDT

Thanks Florian. Changes pushed as kernel commits 35a8cb0ea0125de205d8b02a769817c14ea5191b and 28633df0f7973d13e74a2d02c250c0263962a6db.