Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357400 - CDOPushTransaction.isDirty() should call delegate.isDirty()
Summary: CDOPushTransaction.isDirty() should call delegate.isDirty()
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-12 12:32 EDT by Alex Lagarde CLA
Modified: 2012-09-21 07:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Lagarde CLA 2011-09-12 12:32:35 EDT 
Hi Everyone ! 

A minor bug that is very easy to work around : when using the new remote locking capabilities of CDO by opening a transaction using its durable locking ID, if I create a push transaction and import changes from a file, the following state occurs : pushTransaction.isDirty() return falses although pushTransaction.getDelegate().isDirty() returns true.

It seems raisonnable to add || delegate.isDirty() in the CDOPushTransaction.isDirty() method.


What do you think ?
Comment 1 Eike Stepper CLA 2011-09-19 02:27:35 EDT 
Analyzing in 4.1 first and prting back to 4.0 eventually.
Comment 2 Eike Stepper CLA 2011-09-19 02:37:07 EDT 
Fix for 4.0 is in bug 358055.
Comment 3 Eike Stepper CLA 2011-09-19 02:40:58 EDT 
Committed revision 9171
Comment 4 Eike Stepper CLA 2012-09-21 07:17:54 EDT 
Closing.