Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357387 - Investigate uplift of TestSuites to Apache HttpClient 4.1.x
Summary: Investigate uplift of TestSuites to Apache HttpClient 4.1.x
Status: CLOSED FIXED
Alias: None
Product: Lyo
Classification: Technology
Component: TestSuite (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Fiedler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-12 10:26 EDT by Michael Fiedler CLA
Modified: 2015-03-09 09:52 EDT (History)
1 user (show)

See Also:
sspeiche: review+

Attachments
Update Apache httpclient to 4.1.1. Consume response correctly in event of error. (2.03 KB, patch)
2011-10-24 09:31 EDT, Michael Fiedler CLA 		fiedler.mf: iplog+
Details | Diff
Replace use of deprecated http client API (33.08 KB, patch)
2011-10-24 11:01 EDT, Michael Fiedler CLA 		fiedler.mf: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Fiedler CLA 2011-09-12 10:26:53 EDT 
Build Identifier: 

The test suites see occasional failures where the http client gets into
a bad state - usually do to the failure of an earlier test.

The pattern used in the suites to consume the response content is known
to have issues in the HttpClient 4.0.1 libraries we are using.

HttpClient 4.0.3 and up use a new pattern (HttpEntity#consumeContent())
which I am investigating as a possible solution to these issues.

Please assign this bug to Michael Fiedler

Reproducible: Sometimes

Steps to Reproduce:
Run the CM test suite against the CM RIO you will see connection failures
for the final tests.   These are caused by the http client getting into a 
bad state due to [1].


[1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=357277
Comment 1 Michael Fiedler CLA 2011-10-24 09:31:54 EDT 
Created attachment 205812 [details]
Update Apache httpclient to 4.1.1.   Consume response correctly in event of error.

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use
Comment 2 Michael Fiedler CLA 2011-10-24 09:34:11 EDT 
The attached patch allows SimplifiedQueryXmlTests to continue in event of error.  It fixes the "Incorrect use of SingleClientConnManager" error subsequent tests would get due to improperly closed connections.
Comment 3 Michael Fiedler CLA 2011-10-24 10:42:20 EDT 
Going to make an additional change to hit all usage of the deprecated HttpEntity#consumeContent method.   The current patch fixes the specific issue with leaked connections but we should use the new EntityUtils#consumeContent everywhere.
Comment 4 Michael Fiedler CLA 2011-10-24 11:01:51 EDT 
Created attachment 205831 [details]
Replace use of deprecated http client API
Comment 6 Steve Speicher CLA 2011-10-25 08:51:40 EDT 
See comment 5
Comment 7 Samuel Padgett CLA 2015-03-09 09:52:53 EDT 
Bulk update: Closing out Lyo bugs fixed long ago. Feel free to reopen if you feel your bug was closed in error.