357327 – Small bugfixes for o.e.d.sqltools

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357327 - Small bugfixes for o.e.d.sqltools

Summary: Small bugfixes for o.e.d.sqltools

Status:	RESOLVED FIXED

Alias:	None

Product:	Data Tools
Classification:	Tools
Component:	SQLDevTools (show other bugs)
Version:	unspecified
Hardware:	Macintosh Linux

Importance:	P3 minor (vote)
Target Milestone:	1.9.2
Assignee:	Brian Payton
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-09-11 11:38 EDT by Pierre Queinnec
Modified:	2011-10-05 07:41 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
remove a useless double assignment (1.12 KB, patch) 2011-09-11 11:38 EDT, Pierre Queinnec	no flags	Details \| Diff
fix a FileInputStream leak (1.91 KB, patch) 2011-09-11 11:39 EDT, Pierre Queinnec	no flags	Details \| Diff
fix a possible infinite loop (1.80 KB, patch) 2011-09-11 11:40 EDT, Pierre Queinnec	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pierre Queinnec

2011-09-11 11:38:03 EDT

Build Identifier: git master

This is an umbrella ticket for small patches, mostly bugfixes, on the sqltools git master.

Reproducible: Always

Comment 1 Pierre Queinnec

2011-09-11 11:38:54 EDT

Created attachment 203124 [details]
remove a useless double assignment

Comment 2 Pierre Queinnec

2011-09-11 11:39:38 EDT

Created attachment 203125 [details]
fix a FileInputStream leak

Comment 3 Pierre Queinnec

2011-09-11 11:40:12 EDT

Created attachment 203126 [details]
fix a possible infinite loop

Comment 4 Brian Payton

2011-10-04 16:49:01 EDT

Hi, EGit doesn't like the Git patch format of the supplied patches.  Please use the Eclipse (unified) patch format.  (If you are using Git command line, try "git format-patch --no-prefix")

I applied the patch changes by hand, since the changes were small.

Comment 5 Brian Payton

2011-10-04 17:12:18 EDT

I've committed the changes.  Here's the Git commit record:

http://git.eclipse.org/c/datatools/org.eclipse.datatools.sqltools.git/commit/?id=f00a03f3d74f7b6284171d28c4f344b187964dfc

Please verify that I did the changes correctly.

Comment 6 Pierre Queinnec

2011-10-05 07:41:33 EDT

Looks fine, thanks a lot Brian!