Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357192 - pluginManagement configuration of target-platform-configuration may not apply
Summary: pluginManagement configuration of target-platform-configuration may not apply
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 03:51 EDT by Tobias Oberlies CLA
Modified: 2021-04-28 16:54 EDT (History)
1 user (show)

See Also:


Attachments
standalone project demonstrating the problem (970 bytes, application/x-download)
2013-04-10 09:26 EDT, Tobias Oberlies CLA
no flags Details
example project updated to properly use pluginManagement (1.11 KB, application/zip)
2013-04-10 09:42 EDT, Igor Fedorenko CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Oberlies CLA 2011-09-09 03:51:13 EDT
Tycho reads the configuration of target-platform-configuration from the build/plugins section of the effective POM. As the target-platform-configuration plugin is not part of Tycho's packaging types, the effective POM build/plugins may not contain that plugin. Therefore, a pluginManagement configuration, e.g. in a parent POM, may be ignored.

This is a particular problem of target-platform-configuration. We should change Tycho, e.g. by adding a dummy goal of target-platform-configuration, so that pluginManagement configuration is applied even if the project doesn't mention target-platform-configuration in build/plugins.
Comment 1 Igor Fedorenko CLA 2011-09-09 07:28:47 EDT
Please provide sample project and steps to reproduce the problem.
Comment 2 Tobias Oberlies CLA 2013-04-10 09:26:04 EDT
Created attachment 229553 [details]
standalone project demonstrating the problem
Comment 3 Igor Fedorenko CLA 2013-04-10 09:42:50 EDT
Created attachment 229555 [details]
example project updated to properly use pluginManagement
Comment 4 Igor Fedorenko CLA 2013-04-10 09:49:43 EDT
pluginManagement does not bind plugin to project build lifecycle, it only defines configuration that will be used when/if the plugin is actually bound. This is how maven always worked and this is not specific to tycho in any way. I've attached updated example that shows how to use pluginManagement properly.

Note that we could change tycho to read target-platform-configuration directly from pluginManagement. I am not sure what advantages this will provide however, so will -1 this change unless a compelling reason is provided to justify it.

I am closing this bug report as invalid because tycho behaves as designed, but feel free to reopen if you believe we need to change the design.
Comment 5 Tobias Oberlies CLA 2013-04-10 10:35:24 EDT
(In reply to comment #4)
> feel free to reopen if you believe we need to change the design.
This is why I've opened this bug. 

However I would't expect that this bug is fixed by reading the target-platform-configuration from pluginManagement, but rather when some target-platform-configuration goal  in bound Tycho's packaging types. This is something that may happen after bug 353889 is done.
Comment 6 Mickael Istria CLA 2021-04-08 18:06:21 EDT
Eclipse Tycho is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/tycho/issues/ instead. If this issue is relevant to you, your action is required.
0. Verify this issue is still happening with latest Tycho 2.4.0-SNAPSHOT
  if issue has disappeared, please change status of this issue to "CLOSED WORKFORME" with some details about your testing environment and how you did verify the issue; and you're done
  if issue is still present when latest release:
* Create a new issue at https://github.com/eclipse/tycho/issues/
  ** Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  ** In the GitHub description, start with a link to this bugzilla ticket
  ** Optionally add new content to the description if it can helps towards resolution
  ** Submit GitHub issue
* Update bugzilla ticket
  ** Add to "See also" property (up right column) the link to the newly created GitHub issue
  ** Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  ** Set status as CLOSED MOVED
  ** Submit

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for Tycho will be archived and made read-only.