Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357136 - UITopicBase should not include the word "model" in its value
Summary: UITopicBase should not include the word "model" in its value
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Dean Roberts CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 357135
Blocks: 357255
  Show dependency tree
 
Reported: 2011-09-08 14:33 EDT by Dean Roberts CLA
Modified: 2011-10-26 13:44 EDT (History)
3 users (show)

See Also:

Attachments
Remove name model from UITopicBase (3.27 KB, patch)
2011-09-13 14:26 EDT, Dean Roberts CLA 		no flags Details | Diff
Example of newly generated UIEvents.java (16.82 KB, text/plain)
2011-09-13 14:27 EDT, Dean Roberts CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2011-09-08 14:33:31 EDT 
It appears that we are on the eve of creating non-model related events in E4.  That being the case, I don't believe the root constant UITopicBase should really include the word model.

Whether or not this should be expanded to a rename of the field itself is open to debate.  While not the best name, given it is currently being used for model events only ... it may be too pervasive and entrenched to be changed.
Comment 1 Dean Roberts CLA 2011-09-13 14:26:02 EDT 
Created attachment 203280 [details]
Remove name model from UITopicBase

Refactor the topic name slightly by removing "model" from UITopicBase and creating the constant UIModelTopicBase

In preparation of growing non model events.
Comment 2 Dean Roberts CLA 2011-09-13 14:27:29 EDT 
Created attachment 203282 [details]
Example of newly generated UIEvents.java
Comment 3 Eric Moffatt CLA 2011-09-21 09:53:02 EDT 
Pushed to R4_Development in >20110921. Also includes the new UIEvents.java...

commit a35394839071e957aad2a02bc6ac6bdc19f8315f
Comment 4 Eric Moffatt CLA 2011-09-21 09:53:31 EDT 
Marking FIXED.
Comment 5 Dean Roberts CLA 2011-10-26 13:44:11 EDT 
Verified on I20111014-1625